Bug 433644

Summary: Review Request: perl-Algorithm-CurveFit - Nonlinear Least Squares Curve Fitting
Product: [Fedora] Fedora Reporter: Patrice Dumas <pertusus>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, kevin, notting
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-02-25 22:45:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 433638    
Bug Blocks:    

Description Patrice Dumas 2008-02-20 16:19:30 UTC
Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-Algorithm-CurveFit.spec
SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-Algorithm-CurveFit-1.03-1.fc9.src.rpm
Description: 
Algorithm::CurveFit implements a nonlinear least squares curve fitting
algorithm. That means, it fits a curve of known form (sine-like,
exponential, polynomial of degree n, etc.) to a given set of data points.

Comment 1 Parag AN(पराग) 2008-02-25 04:59:07 UTC
Review:
+ package builds in mock (development i386).
koji build=>http://koji.fedoraproject.org/koji/taskinfo?taskID=466864
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7de2637286628510aad586260ebcd2b4  Algorithm-CurveFit-1.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=9,  1 wallclock secs ( 0.80 cusr +  0.05 csys =  0.85 CPU)
+ Package perl-Algorithm-CurveFit-1.03-1.fc9 =>
  Provides: perl(Algorithm::CurveFit) = 1.03
  Requires: perl >= 0:5.006 perl(Carp) perl(Data::Dumper) perl(Exporter)
perl(Math::MatrixReal) perl(Math::Symbolic) perl(strict) perl(warnings)
APPROVED.

Comment 2 Patrice Dumas 2008-02-25 08:44:05 UTC
New Package CVS Request
=======================
Package Name: perl-Algorithm-CurveFit
Short Description: Nonlinear Least Squares Curve Fitting
Owners: pertusus
Branches: F-7 F-8 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes


Comment 3 Kevin Fenzi 2008-02-25 21:33:54 UTC
cvs done.

Comment 4 Patrice Dumas 2008-02-25 22:03:07 UTC
I did a 
cvs co perl-Algorithm-CurveFit 
from my top-level fedora development directory. Then 
cd perl-Algorithm-CurveFit 
and
./common/cvs-import.sh ~/RPM-fc/SRPMS/perl-Algorithm-CurveFit-1.03-1.fc9.src.rpm

everything seems right, I enter the initial commit message, but then:

**** Access denied: pertusus is not in ACL for rpms/perl-Algorithm-CurveFit/devel
cvs commit: Pre-commit check failed
cvs [commit aborted]: correct above errors first!
cvs commit: saving log message in /tmp/cvsNyKKkD

Am I missing something ??

Comment 5 Kevin Fenzi 2008-02-25 22:21:06 UTC
From: 
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

"After your request is granted, please wait for the next CVS sync which occurs
every 30 minutes."

I suspect you just missed the sync. Can you try again now? 

Comment 6 Patrice Dumas 2008-02-25 22:45:58 UTC
OOps. Sorry for the mistake... Thanks Parag for the review, and
thanks and sorry Kevin for the branching...

Imported and built.