Bug 433735
Summary: | Review Request: libgcroots - Root acquisition library for Garbage Collector | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Akira TAGOH <tagoh> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-03-05 02:42:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Akira TAGOH
2008-02-21 02:36:23 UTC
missing Requires:pkgconfig on -devel subpackage. Thanks for catching that up. updated: http://tagoh.fedorapeople.org/libgcroots/libgcroots.spec http://tagoh.fedorapeople.org/libgcroots/libgcroots-0.2.1-2.fc9.src.rpm Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=472349 + rpmlint is silent for SRPM and for RPM. + source files match upstream url f5fa9b60e506c70a041ef03ab26dbd18 libgcroots-0.2.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + gcroots.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libgcroots-0.2.1-2.fc9-> Provides: libgcroots.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libdl.so.2 libgcroots.so.0 rtld(GNU_HASH) + Package libgcroots-devel-0.2.1-2.fc9 -> Requires: libgcroots.so.0 pkgconfig libgcroots = 0.2.1-2.fc9 + Not a GUI App. APPROVED. Thanks for reviewing. New Package CVS Request ======================= Package Name: libgcroots Short Description: Root acquisition library for Garbage Collector Owners: tagoh Branches: devel InitialCC: Cvsextras Commits: yes cvs done. Imported and the build went well. thanks! |