Bug 434806

Summary:	xenfb can crash when probe fails
Product:	Red Hat Enterprise Linux 5	Reporter:	Markus Armbruster <armbru>
Component:	kernel-xen	Assignee:	Markus Armbruster <armbru>
Status:	CLOSED DUPLICATE	QA Contact:	Martin Jenner <mjenner>
Severity:	medium	Docs Contact:
Priority:	low
Version:	5.1	CC:	xen-maint
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-07-21 16:43:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	434802
Bug Blocks:	448753

Description Markus Armbruster 2008-02-25 16:32:08 UTC

Description of problem:
xenfb_probe() dereferences null info->fb_info when register_framebuffer() fails.

How reproducible:
Haven't tried.

Comment 1 Markus Armbruster 2008-02-26 14:33:21 UTC

register_framebuffer() fails when FB_MAX framebuffers are already registered.  I
doubt this can happen, because the device is compiled in and thus probes fairly
early.

When the bug bites, the driver dereferences a null pointer during cleanup from
the failed probe.

Comment 2 Markus Armbruster 2008-02-26 15:12:15 UTC

See bug 434802 for a proposed fix.

Comment 3 RHEL Program Management 2008-06-09 21:58:40 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 5 Markus Armbruster 2008-07-21 16:43:52 UTC

The proposed fix from bug 434802 has been committed as a fix for bug 434800. 
Turning this one into a duplicate of 434800 to keep things simple and sane.

*** This bug has been marked as a duplicate of 434800 ***