Bug 434815

Summary: Add -DKDE_DISTRIBUTION_TEXT="Fedora packages" to %{cmake_kde4} in /etc/rpm/macros.kde4
Product: [Fedora] Fedora Reporter: Laurent Rineau <laurent.rineau__fedora>
Component: kdelibsAssignee: Lukáš Tinkl <ltinkl>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: jgrulich, kevin, ltinkl, rdieter, than
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-02-27 14:26:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Laurent Rineau 2008-02-25 17:11:07 UTC
Dear KDE SIG,

  In the CMake cache variable for KDE4 (in kdelibs at least), there exists a 
cache variable named "KDE_DISTRIBUTION_TEXT" with default value "compiled 
source". That string is used by the KBugReport dialogs (see file 
kdeui/dialogs/kbugreport.cpp in kdelibs-4.0.1, line 213). It should be better, 
in Fedora packages, to set it to "Fedora packages", or perhaps maybe "Fedora 
package %{name}-%{version}-%{release}". I propose that change to be applied 
to %{cmake_kde4} in /etc/rpm/macro.kde4, so that all rebuild will have that 
change:
  -DKDE_DISTRIBUTION_TEXT="Fedora package %{name}-%{version}-%{release}"

(I have not tested my proposal.)

Debian packages use "Debian packages", and Ubuntu packages strangely 
use "Kubuntu packages". See for example 
http://archive.ubuntu.com/ubuntu/pool/universe/k/kde4libs/kde4libs_4.0.1-0ubuntu1.diff.gz

Comment 1 Kevin Kofler 2008-02-25 21:55:10 UTC
Ubuntu packages using "Kubuntu packages" is not strange, Kubuntu is just 
Ubuntu's KDE spin, they use the same repositories, so the packages you're 
seeing at archive.ubuntu.com are maintained by the Kubuntu team and are the 
ones which end up in Kubuntu releases.

But yes, setting KDE_DISTRIBUTION_TEXT sounds like a good idea to me.

Comment 2 Lukáš Tinkl 2008-02-27 14:26:06 UTC
Will be in builds >= 4.0.1-8