Bug 435227

Source0 is a 404:

http://5b4az.chronos.org.uk/pkg/psk31/xpsk31/xpsk31-0.7.tar.gz

Upstream apparently deletes old source, the new source will require a version
bump http://5b4az.chronos.org.uk/pkg/psk31/xpsk31/xpsk31-0.8.tar.gz

Some pre-review pointers:- 

- Use of 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
is recommended as it keeps the timestamps on installed files. This is useful 
for recent autotools based make file.

- INSTALL file is not required in %doc section as it is used to install from 
the source. RPM installation does not require INSTALL file.

I am going to stall this review for a couple days, Upstream has other related
packages I would like to also get in to the review process, they all will need
similar fixes.

I tried to update this package and ran in to problems. I will try again and
collect the build log if someone does not beat me to is.

Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xpsk31.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xpsk31-0.8-1.fc8.src.rpm

Koji build on dist-f9:

http://koji.fedoraproject.org/koji/taskinfo?taskID=484167

Fails on missing po/Makefile.in.in:

==
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: error: cannot find input file: po/Makefile.in.in
error: Bad exit status from /var/tmp/rpm-tmp.91780 (%build)
==

Changing status to NEEDINFO from Reporter

Hello,

I'm taking over this review request because bob has some problems
I've corrected spec file and bumped version

new files:
http://lucilanga.fedorapeople.org/xpsk31.spec
http://lucilanga.fedorapeople.org/xpsk31-0.8-2.fc9.src.rpm

The source tarball is a 404, again, and it seems upstream has a new version 1.2
that builds with the same spec and patches

RPM Lint: OK, silent
Package name: OK
Spec file: OK
License: OK, GPLv2+
Actual License: OK, no license file but code says GPLv2+
%doc License: No, license is in the code
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: Upstream tarball disappears when new version
is released. Newer version 1.2 builds with the same spec and the same patches,
so no problem. Might wanna contact upstream to make them have the tarballs
around a little longer though.

Compile and Build:
- F-7: OK
- F-8: OK
- rawhide: OK
- EL-5: OK

Applicable Package Guidelines:

Locales: N/A
Shared libs: N/A

Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

package approved in principle, but you might want to bump the version and
contact upstream about the disappearing tarballs.

> The source tarball is a 404, again, and it seems upstream has a new version 1.2
> that builds with the same spec and patches

Verified building with 1.2, I will initial import the newer version and contact
upstream.

New Package CVS Request
=======================
Package Name: xpsk31
Short Description: GTK+ graphical version of lpsk31 for Ham Radio
Owners: lucilanga,bjensen
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes

New Package CVS Request
=======================
Package Name: xpsk31
Short Description: GTK+ graphical version of lpsk31 for Ham Radio
Owners: lucilanga,bjensen
Branches: F-8 F-9 EL-5
InitialCC: 
Cvsextras Commits: yes

cvs done.

xpsk31-1.2-1.fc9 has been submitted as an update for Fedora 9

xpsk31-1.2-1.fc8 has been submitted as an update for Fedora 8

xpsk31-1.2-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

xpsk31-1.2-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.