Bug 435231

Summary: Review Request: xlog - Logging program for Ham Radio Operators
Product: [Fedora] Fedora Reporter: Robert 'Bob' Jensen <bob>
Component: Package ReviewAssignee: Lucian Langa <lucilanga>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, kevin, lucilanga, notting, vanmeeuwen+fedora
Target Milestone: ---Flags: vanmeeuwen+fedora: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-08-03 16:15:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Robert 'Bob' Jensen 2008-02-28 03:46:23 UTC
Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xlog.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xlog-1.7-1.fc8.src.rpm
Description: xlog is a logging program for amateur radio operators. The log is stored into a text file. QSO's are presented in a list. Items in the list can be added, deleted or updated. For each contact, dxcc information is displayed and bearings and distance is calculated, both short and long path. xlog supports trlog, adif, cabrillo, edit, twlog and editest files.

This srpm mock builds against Fedora 8 and devel. All resulting rpms are rpmlint clean. Fedora 7 is not a target for this package.

Comment 1 Jeroen van Meeuwen 2008-02-28 23:52:44 UTC
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: OK
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum)
Compile and Build:
 - F-7: FAILED (but not a target)
 - F-8: OK
 - rawhide: OK
 - EL-5: FAILED (but not a target)

Applicable Package Guidelines:
 - -debuginfo package: OK (~444k)
Locales: OK
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: See suggestions
File Permissions: OK
Macro usage: See suggestions
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: OK
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

in %prep, invoke sed using the %{_sed} macro. Consider using '-i -e' for inline
regexp replacement (instead of moving the file around). Better yet, create and
apply a patch here.

AUTHORS file is in both %doc and %{_datadir}/xlog/, same goes for BUGS and
ChangeLog. I guess the files in %{_datadir}/xlog should go into %docs as well.

Comment 2 Lucian Langa 2008-07-17 15:02:36 UTC
Hello,

Bob is having some problems so I will take over this.

> in %prep, invoke sed using the %{_sed} macro. Consider using '-i -e' for inline
> regexp replacement (instead of moving the file around). Better yet, create and
> apply a patch here.
modified to use sed inline

> AUTHORS file is in both %doc and %{_datadir}/xlog/, same goes for BUGS and
> ChangeLog. I guess the files in %{_datadir}/xlog should go into %docs as well.
I've moved all files to %doc and dropped package doc install procedure.

.. and bumped file version
new files:
http://lucilanga.fedorapeople.org/xlog.spec
http://lucilanga.fedorapeople.org/xlog-1.7-2.fc9.src.rpm

Comment 3 Jeroen van Meeuwen 2008-08-02 09:35:52 UTC
Very well, package approved

Comment 4 Lucian Langa 2008-08-02 09:47:30 UTC
New Package CVS Request
=======================
Package Name: xlog
Short Description: Logging program for Hamradio Operators
Owners: lucilanga,bjensen
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2008-08-03 04:05:30 UTC
cvs done.

Comment 6 Fedora Update System 2008-08-03 16:14:08 UTC
xlog-1.7-2.fc9 has been submitted as an update for Fedora 9

Comment 7 Fedora Update System 2008-08-03 16:14:32 UTC
xlog-1.7-2.fc8 has been submitted as an update for Fedora 8

Comment 8 Fedora Update System 2008-08-12 18:22:11 UTC
xlog-1.7-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2008-08-12 18:27:22 UTC
xlog-1.7-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.