Bug 435347

Summary:	Review Request: egd - Entropy Gathering Daemon
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Ed Hill <ed>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	ed: fedora-review+ tcallawa: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-03-11 02:23:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom "spot" Callaway 2008-02-28 19:58:49 UTC

Spec URL: http://www.auroralinux.org/people/spot/review/new/egd.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/egd-0.9-1.fc9.src.rpm
Description: 
EGD is an Entropy Gathering Daemon meant to be used on systems that can run GPG
but which don't have a convenient (or reliable) source of random bits. It is a
regular user-space program that sits around, running programs like 'w' and
'last' and 'vmstat', collecting the randomness (or at least the
unpredictability) inherent in the output of these system statistics programs
when used on a reasonably busy system. It slowly stirs the output of these
gathering programs into a pool of entropy, much like the linux kernel device,
and allows other programs to read out random bits from this pool.

Comment 1 Ed Hill 2008-03-09 00:13:39 UTC

Here's a quick review:

 + package name ok
 + spec macros look ok
 + both licenses are listed and is correctly included
 + spec is legible
 + source matches upstream sha1sum:
    dc1c3c0d28814c8ee870d8604c9c1603e1a44819  egd-0.9.tar.gz
    dc1c3c0d28814c8ee870d8604c9c1603e1a44819  egd-0.9.tar.gz.1
 + builds in mock for F8 x86_64
 + rpmlint is silent
 + no libs/*.la/-devel/etc.
 + dir ownership looks ok
 + clean exists and 'rm -rf $RPM_BUILD_ROOT' in install
 + installs and works-for-me
 
I don't see any blockers so its APPROVED.

Comment 2 Tom "spot" Callaway 2008-03-10 19:09:50 UTC

New Package CVS Request
=======================
Package Name: egd
Short Description: Entropy Gathering Daemon 
Owners: spot
Branches: F-7 F-8 devel
InitialCC: 
Cvsextras Commits: yes

Comment 3 Tom "spot" Callaway 2008-03-11 02:23:14 UTC

Built in rawhide (and F-7/F-8). Thanks for the review!