Bug 435383

Summary: typo in iscsi _getParser(self)
Product: Red Hat Enterprise Linux 5 Reporter: James Laska <jlaska>
Component: pykickstartAssignee: Chris Lumens <clumens>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 5.2CC: jturner
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-28 23:01:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 435451    

Description James Laska 2008-02-28 22:08:36 UTC
diff --git a/pykickstart/commands/iscsi.py b/pykickstart/commands/iscsi.py
index f967056..e1339f7 100644
--- a/pykickstart/commands/iscsi.py
+++ b/pykickstart/commands/iscsi.py
@@ -70,7 +70,7 @@ class FC6_Iscsi(KickstartCommand):
 
     def _getParser(self):
         op = KSOptionParser(lineno=self.lineno)
-        op.add_option("--target", dest="ipaddr", action="store", type="string")
+        op.add_option("--target", dest="target", action="store", type="string")
         op.add_option("--ipaddr", dest="ipaddr", action="store", type="string",
                       required=1)
         op.add_option("--port", dest="port", action="store", type="string")

Comment 1 James Laska 2008-02-29 14:26:27 UTC
Ooops, I guess the RHEL5 version of this patch would be:

diff --git a/pykickstart/parser.py b/pykickstart/parser.py
index a37baa0..1aa538b 100644
--- a/pykickstart/parser.py
+++ b/pykickstart/parser.py
@@ -431,7 +431,7 @@ class KickstartHandlers:
 
     def doIscsi(self, args):
         op = KSOptionParser(lineno=self.lineno)
-        op.add_option("--target", dest="ipaddr", action="store", type="string")
+        op.add_option("--target", dest="target", action="store", type="string")
         op.add_option("--ipaddr", dest="ipaddr", action="store", type="string",
                       required=1)
         op.add_option("--port", dest="port", action="store", type="string")



Comment 2 Chris Lumens 2009-07-28 23:01:12 UTC
This is fixed in pykickstart head, and we haven't gotten any other reports about this in RHEL5 so I'm going to go ahead and close as NEXTRELEASE.  I wonder if this means that no one is actually using the kickstart iscsi command.  If someone is and runs across this, we can always reopen.