Bug 435431
| Summary: | Review Request: ocaml-deriving - Extension to OCaml for deriving functions from types | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-14 20:34:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard W.M. Jones
2008-02-29 10:21:25 UTC
License: should be MIT. The COPYING file says "The MIT License" and indeed our licensing guidelines agree with that. I had guessed that this one would have a .cmo file but it doesn't. So I guess I'm still pretty confused about that. The only issue is the license tag, and that's a trivial fix so I'll approve this and you can fix it when you check in. * source files match upstream: ab9e5403a383d57b3572b21587a23dc2f85980b0a95936ac748ccd2118c4f55e deriving-0.1.1a.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. APPROVED X license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane; listed above so no point in repeating them. * %check is present and all tests pass: Tests succeeded! * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files (besides COPYING file) * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * .cma, .cmi, .so, .so.owner, META files in the main package. * .a, .cmxa, .cmx and .mli files are in the -devel subpackage. * .cmo, .o and .ml files not included License: Yes, it's MIT. Particularly stupid on my part because I even asked upstream to release a new version (0.1.1a) with the license file included, but then I forgot to fix my spec file :-( Lack of *.cmo file: This is a one-of-a-kind upstream. Normal syntax extensions are loadable object files (*.cmo) so they get loaded into the normal OCaml parser at compile time. The object files consist of a list of instructions for the parser, like 'add this keyword', 'delete this parsing rule', 'substitute this other parsing rule'. This means that syntax extensions are composable (you can use more than one at a time). But for this one, upstream have linked the syntax extension to a standalone program (/usr/bin/deriving) which one is supposed to use as a preprocessor (it takes OCaml + deriving syntax and emits basic OCaml). I've just realised that this is not a smart upstream choice because it prevents the syntax from being composable with other syntaxes, so you cannot mix the deriving syntax with any other syntax extension. Here's a new package: Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-deriving.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-deriving-0.1.1a-3.fc9.src.rpm * Mon May 10 2008 Richard W.M. Jones <rjones> - 0.1.1a-3 - Fix the License tag (MIT not BSD). * Wed Mar 5 2008 Richard W.M. Jones <rjones> - 0.1.1a-2 - Remove ExcludeArch ppc64. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=604494 Just a reminder; this package was already approved. The new package is fine. So it was, I missed that :-) Thanks for this and many other reviews. I know they can be quite tedious at times to do. CVS request comin' up ... New Package CVS Request ======================= Package Name: ocaml-deriving Short Description: Extension to OCaml for deriving functions from types Owners: rjones Branches: F-8 F-9 InitialCC: rjones Cvsextras Commits: yes cvs done. Built in F8/F9/devel. Thanks for everyone's help. |