Bug 435542
| Summary: | Review Request: xdemorse - GTK based application for decoding and displaying Morse code signals | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert 'Bob' Jensen <bob> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lucilanga, notting, vanmeeuwen+fedora |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-07-16 18:07:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert 'Bob' Jensen
2008-03-01 10:40:06 UTC
some notes - you should add the doc/xdemorse.html as %doc too (README and ChangeLog are referring to it) - you should ask upstream to include the license text into ythe source archive - when trying to run xdemorse, I am getting an error "Failed to open xdemorserc file. Quit xdemorse and correct" Formal review: OK source files match upstream: c42e15d6056ac7aa3ab8981c9e689ed43770205b xdemorse-0.9.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (F-8/x86_64, Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app, desktop file included So before final approval I need from you to update the %doc with the manual and fix (or explain) the xdemorserc issue. (In reply to comment #1) > some notes > - you should add the doc/xdemorse.html as %doc too (README and ChangeLog are > referring to it) > - you should ask upstream to include the license text into ythe source archive > - when trying to run xdemorse, I am getting an error "Failed to open xdemorserc > file. Quit xdemorse and correct" ... > > So before final approval I need from you to update the %doc with the manual and > fix (or explain) the xdemorserc issue. The solution could be some demo xdemorserc in %doc. These should resolve the existing issues. Please review completely to be sure. New Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xdemorse.spec New SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xdemorse-0.9-3.fc9.src.rpm I think you missed to include doc/xdemorse.html as %doc. Using a wrapper to create the config file is a good idea. I did a scratch build (http://koji.fedoraproject.org/koji/taskinfo?taskID=490483) and it looks good (perhaps some timeout on ppc builder, as I got the same on ppc64 after requeue), so please update the %doc and we are at the end. ping Hello, sorry for the long delay, Bob is having some serious problems and I will take over this: I've added doc/xdemorse.html to %doc and bumped version. new files are: http://lucilanga.fedorapeople.org/xdemorse.spec http://lucilanga.fedorapeople.org/xdemorse-0.9-4.fc9.src.rpm OK, now is this package APPROVED New Package CVS Request ======================= Package Name: xdemorse Short Description: GTK based application for decoding and displaying Morse code signals Owners: lucilanga,bjensen Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. xdemorse-0.9-4.fc9 has been submitted as an update for Fedora 9 |