Bug 435564

Trivial to review noarch packaging. But:

* Package lure needs scummvm >= 0.11.1, this is not available.

With both Rawhide and F8.

With the one from F8 it is incomplete (desktop file fails).

With the one from Rawhide, it starts, but complains about an
incorrect lure.dat version (1.28, expected 1.29) and drops back
into X at 640x480 plus a frozen mouse-pointer.

(In reply to comment #1)
> Trivial to review noarch packaging. But:
> 

Thanks!

> * Package lure needs scummvm >= 0.11.1, this is not available.
> 
> With both Rawhide and F8.
> 

Oops, I prepared a scummvm-0.11.1, but somehow forgot to commit, tag and build
it. Its on its way to rawhide now. I plan to build and release it for F-8
together with lure as one update.

> With the one from F8 it is incomplete (desktop file fails).
> 

Thats expected its to old.

> With the one from Rawhide, it starts, but complains about an
> incorrect lure.dat version (1.28, expected 1.29) and drops back
> into X at 640x480 plus a frozen mouse-pointer.
> 

The incorrect lure.dat message is expected, thats why it needs 0.11.1 not
0.11.0, the X being in the low resolution and frozen mouse pointer isn't. I had
the same error with 0.11.1 the other way around (too old lure.dat) and there
after the error the resolution and mouse were restored properly, so I guess this
is fixed with 0.11.1

The sound is heavily distorted as soon as multiple channels are
mixed. Is this specific to Lure or a bug in scummvm?

(In reply to comment #3)
> The sound is heavily distorted as soon as multiple channels are
> mixed. Is this specific to Lure or a bug in scummvm?
> 

It was a specific lure bug, I say was as I just spend an entire day hunting it
down. koji has scummvm-0.11.1-2 know, which fixes this.

Also I'm seriously considering changing the desktop file to launch lure like
this, as that uses general midi emulation instead of adlib emulation:
scummvm -efluidsynth --soundfont=/usr/share/soundfonts/PCLite.sf2 -p
/usr/share/lure lure

Note that in order to actually have a /usr/share/soundfonts/PCLite.sf2 file you
need to have PersonalCopy-Lite-soundfont installed (I'll add a requires for 
PersonalCopy-Lite-soundfont to lure if I change the .desktop file to launch lure
like this).

Please let me know how the new scummvm works for you and if you like the
alternative way of launching lure?

Here is a new version with the proposed changes:
Spec URL: http://people.atrpms.net/~hdegoede/lure.spec
SRPM URL: http://people.atrpms.net/~hdegoede/lure-1.1-2.fc9.src.rpm

> +# Requires: PersonalCopy-Lite-soundfont as our .desktop file passes cmdline
> +# options to scummvm to use fluidsynth midi emulation, which needs a soundfont
> +# This is done because with lure the default adlib emulation sounds rather poor
> +Requires:       scummvm >= 0.11.1-2, PersonalCopy-Lite-soundfont

The good news, the sound-fix works fine.

The bad news, I wholeheartedly disagree with the above comment.
For a game soundtrack from the early 90's, AdLib audio was the
better choice and the de facto standard (in popular soundcards
such as the Sound Blaster or Pro Audio Spectrum series). In many
cases, the musicians and composers created their soundtracks for
AdLib or OPL{2,3} hardware and drivers. A lot of synthetic
instruments cannot be replaced with GM samples without sounding
weird and doubtful. Switching Lure to GM emulation sounds worse.

So, thumbs up only for the combination of:

$ rpm -q scummvm lure
scummvm-0.11.1-2.fc9
lure-1.1-1.fc8

(In reply to comment #6)
> The bad news, I wholeheartedly disagree with the above comment.
> For a game soundtrack from the early 90's, AdLib audio was the
> better choice and the de facto standard (in popular soundcards
> such as the Sound Blaster or Pro Audio Spectrum series). In many
> cases, the musicians and composers created their soundtracks for
> AdLib or OPL{2,3} hardware and drivers. A lot of synthetic
> instruments cannot be replaced with GM samples without sounding
> weird and doubtful. Switching Lure to GM emulation sounds worse.
> 

Hmm, well a problem with the adlib emulation is that its very soft (for example
still a bit soft when using my pc-speakers with all volume controls cranked up
to maximum).

But other then that in retrospect I agree it sounds better (I had been listening
to lure's music soundeffects for 2 full days, while working on fixing the sound.
I guess that influenced made my earlier call)

So I'll import the 1.1-1 version wich uses the upstream default adlib sound.

New Package CVS Request
=======================
Package Name:      lure
Short Description: Lure of the Temptress - Adventure Game
Owners:            jwrdegoede
Branches:          F-8
InitialCC: 
Cvsextras Commits: Yes

cvs done.

Imported and build, closing.

p.s.

Michael, thanks for the review!