Bug 435578
| Summary: | Review Request: unison227 - File synchronization tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stephen Warren <swarren> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, notting, pertusus |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | unison227-2.27.57-7.fc8.2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-04-17 05:30:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Stephen Warren
2008-03-02 00:54:28 UTC
Just in case anybody is holding off reviewing this because they aren't sure whether replacing the existing unison package is A Good Thing, the existing maintainer said this: Sorry for taking so long, but currently I have other problems to deal with. You can take over maintainership of the unison packages if you want. I can also co-maintain the packages, but I don't know when I have the time to review them. I presume you have made some changes concerning alternatives? I am interested in reviewing that package (and the other one), but I am also very short on time. Updated per comments in bug 433915. Spec URL: http://avon.wwwdotorg.org/downloads/unison227/unison227.spec SRPM URL: http://avon.wwwdotorg.org/downloads/unison227/unison227-2.27.57-6.fc8.src.rpm Note to self: Remember to file a bug re: ExcludeArch: PPC64 (see FE-ExcludeArch-ppc64, bug 238953) because the ocaml native compiler isn't available on PPC64. Updated per comments in bug 433915. Spec URL: http://avon.wwwdotorg.org/downloads/unison227/unison227.spec SRPM URL: http://avon.wwwdotorg.org/downloads/unison227/unison227-2.27.57-7.fc8.src.rpm I'd be happy to review this package. Look for a full review in a bit... Note that this package/spec is pretty much identical to the unison213 package
that was just recently reviewed.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
4ba0a3e4bf4b4ad0c063f86391371f78 unison-2.27.57.tar.gz
4ba0a3e4bf4b4ad0c063f86391371f78 unison-2.27.57.tar.gz.orig
See below - Package needs ExcludeArch
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
Issues:
1. Note that you don't need the excludearch for ppc64 on devel/rawhide,
but you currently still do on f7/f8. :(
You might want to file blocker bugs on that to make sure it's
added as soon as ocaml is available for ppc64 f7/f8
I don't see any blockers here, this package is APPROVED.
New Package CVS Request ======================= Package Name: unison227 Short Description: Multi-master File synchronization tool Owners: swarren,gemi Branches: F-7 F-8 devel EL-4 EL-5 Cvsextras Commits: yes cvs done. I would suggest pushing this package and the other unison one into rawhide and letting them be there a few days before pushing the other branches, just to make sure everything works as expected. his package is now in F7 stable, F8 stable, and devel, hence closing out this bug. |