Bug 435623

Summary:	Review Request: php-pdb - PHP classes for manipulating Palm OS databases
Product:	[Fedora] Fedora	Reporter:	Richard Fearn <richardfearn>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	bugs.michael: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-05-04 16:27:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard Fearn 2008-03-02 18:22:55 UTC

Spec URL: http://richardfearn.co.uk/files/fedora/php-pdb-1.3.4-1/php-pdb.spec
SRPM URL: http://richardfearn.co.uk/files/fedora/php-pdb-1.3.4-1/php-pdb-1.3.4-1.fc8.src.rpm
Description:

Hello,

I'm looking for a sponsor for my second package, php-pdb.

PHP-PDB is a set of PHP classes that manipulate Palm OS databases. It lets you
read, write, alter, and easily use data that is meant to be sent to or
retrieved from a handheld.

The SRPM builds using mock against Fedora 8 and development. The resulting RPMs are both rpmlint clean.

Comment 1 Michael Schwendt 2008-05-01 16:53:19 UTC

APPROVED

No run-time testing done.
Only the standard recommendation:

* Prefer "install -p ..." wherever installing pre-built files.

Plus I would move the "-m 644" to the beginning of the install args
and possibly add "-m 0755" when creating the directories.

Comment 2 Richard Fearn 2008-05-01 19:46:02 UTC

> * Prefer "install -p ..." wherever installing pre-built files.
> 
> Plus I would move the "-m 644" to the beginning of the install args
> and possibly add "-m 0755" when creating the directories.

Thanks for that. I'll put a new version on here soon.

Comment 3 Michael Schwendt 2008-05-01 20:00:22 UTC

No need to. :)
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

Comment 4 Richard Fearn 2008-05-02 21:21:32 UTC

New Package CVS Request
=======================
Package Name: php-pdb
Short Description: PHP classes for manipulating Palm OS databases
Owners: richardfearn
Branches: F-9
InitialCC: 
Cvsextras Commits: yes

Thanks in advance to the CVS admins!

Comment 5 Kevin Fenzi 2008-05-02 22:24:35 UTC

cvs done.