Bug 436037
| Summary: | gdb remote fails qemu: "Value being assigned to is no longer active" | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John Reiser <jreiser> | ||||
| Component: | gdb | Assignee: | Jan Kratochvil <jan.kratochvil> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 8 | CC: | dvlasenk, jan.kratochvil, kevinb | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | i386 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | gdb-6.8-16.fc9 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-08-01 14:32:56 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
John Reiser
2008-03-04 22:27:55 UTC
Created attachment 313103 [details]
Fix
<jkratoch> as frame_find_by_id() should have returned current_Frame itself
<jkratoch> and the question is why it did not do so.
<dvlasenk> i actually took the idea from there
<dvlasenk> a comment says "should be return get_current_frame () instead?"
<jkratoch> But so far it should be run through the testsuite regressions test
(you can run it locally for x86_64+i386) and sure it would be great at least
for Rawhide.
<dvlasenk> but OTOH: what if some user of frame_find_by_id() does NOT want this
behavior?
<jkratoch> It is all a mess now.
<jkratoch> Then the caller of it should be changed...
<dvlasenk> It's better to return NULL, and whoever wants get_current_frame ()
can trivially do "f = frame_find_by_id() ? : get_current_frame ()"
<jkratoch> That is the problem, that the code currently have different
expectations at different places so the fix of it all is a lot of changes, this
is the reason why it is still not fixed up.
<jkratoch> So each caller of frame_find_by_id() should do this hack?
<jkratoch> Why frame_find_by_id() should not return the right value in the
first place
<jkratoch> and rather to fix those who have the wrong NULL value expectations?
<dvlasenk> if there are many callers which want this, we can wrap it into
frame_find_by_id_or_get_current()
No testsuite regressions on x86_64 machine. The regression, if there is an undetected one, would look like this: instead of refusing to touch a value of an expression which is out of scope, a value of the same expression in bottom-most frame is modified. The next Fedora GDB update will come with the fix. gdb-6.8-17.fc9 has been submitted as an update for Fedora 9 gdb-6.8-17.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. FYI this patch is going to be dropped as it is no longer reproducible with Fedora 31 tools. Tested by Kevin Buettner. |