Bug 436330

I'll review this.

- The spec you mentioned from the URL does not match the spec in the SPRM
  - Make sure that the /sbin/ldconfig lines are as follows:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

- Don't use %{name}-latest in the URL, use %{name}-%{version}. Yes, the URL is
still valid.

- libtrash.i386: W: devel-file-in-non-devel-package /usr/lib/libtrash.so
  - move %{_libdir}/libtrash.so to a -devel package

- Other rpmlint errors:
  - libtrash.i386: E: no-ldconfig-symlink /usr/lib/libtrash.so.3.2

First at all, thank you for reviewing :-)

(In reply to comment #2)
> - The spec you mentioned from the URL does not match the spec in the SPRM

Fixed.

> - Make sure that the /sbin/ldconfig lines are as follows:
> 
> %post -p /sbin/ldconfig
> 
> %postun -p /sbin/ldconfig

Yes, the lines look like those above.

> - Don't use %{name}-latest in the URL, use %{name}-%{version}. Yes, the URL is
> still valid.

Fixed.

> - libtrash.i386: W: devel-file-in-non-devel-package /usr/lib/libtrash.so
>   - move %{_libdir}/libtrash.so to a -devel package

This library is the core of libtrash package. So I think, that it doesn't make a
sense to make another package. If so, then the first package would contain only
configuration file and doc files and the second one would contain only the
library. Furthermore, the first one would have to have second one in
requirements, otherwise the whole thing will not work.

> - Other rpmlint errors:
> - libtrash.i386: E: no-ldconfig-symlink /usr/lib/libtrash.so.3.2

Fixed.

Spec URL: http://zprikryl.fedorapeople.org/libtrash.spec
SRPM URL: http://zprikryl.fedorapeople.org/libtrash-3.2-1.fc10.src.rpm

(In reply to comment #3)
> This library is the core of libtrash package. So I think, that it doesn't make a
> sense to make another package. If so, then the first package would contain only
> configuration file and doc files and the second one would contain only the
> library. Furthermore, the first one would have to have second one in
> requirements, otherwise the whole thing will not work.

You need to keep the libraries with numbered extensions (libtrash.so.3.2 and
libtrash.so.3) in the main package, while moving the non-numbered one
(libtrash.so) to the -devel package.

More things:
- You should have updated the NVR (3.2-2 instead of 3.2-1) for the updated
release of this package.

- E: no-ldconfig-symlink /usr/lib/libtrash.so.3.2 is still not fixed. This
message only comes up when building the binary RPM.

(In reply to comment #4)
> You need to keep the libraries with numbered extensions (libtrash.so.3.2 and
> libtrash.so.3) in the main package, while moving the non-numbered one
> (libtrash.so) to the -devel package.

Fixed.

> - You should have updated the NVR (3.2-2 instead of 3.2-1) for the updated
> release of this package.

Fixed

> - E: no-ldconfig-symlink /usr/lib/libtrash.so.3.2 is still not fixed. This
> message only comes up when building the binary RPM.

Hmm, when I try to build binary package I don't see this message. Do you have
any idea why this error message comes up? I use rpm-build-4.4.2.3-2.fc9.i386.

Spec URL: http://zprikryl.fedorapeople.org/libtrash.spec
SRPM URL: http://zprikryl.fedorapeople.org/libtrash-3.2-3.fc10.src.rpm

"%package -n libtrash-devel" and the like should be replaced with "%package
devel". It assumes the libtrash part automatically.

The summary on -devel should be more like the main package summary. Most
notably, rpmlint complains about the first letter not being capitalized, so be
sure to fix that. (libtrash-devel.i386: W: summary-not-capitalized libtrash
dynamic library)

libtrash-devel.i386: W: no-documentation
  Just adding the same documentation as the main package would work.

The strange no-ldconfig-symlink error doesn't show up anymore. I did a yum
update between rpmlints, and I think some RPM stuff got updated.

(In reply to comment #6)
> "%package -n libtrash-devel" and the like should be replaced with "%package
> devel". It assumes the libtrash part automatically.

Fixed

> The summary on -devel should be more like the main package summary. Most
> notably, rpmlint complains about the first letter not being capitalized, so be
> sure to fix that. (libtrash-devel.i386: W: summary-not-capitalized libtrash
> dynamic library)

Fixed

> libtrash-devel.i386: W: no-documentation
>   Just adding the same documentation as the main package would work.

Added.

Spec URL: http://zprikryl.fedorapeople.org/libtrash.spec
SRPM URL: http://zprikryl.fedorapeople.org/libtrash-3.2-4.fc10.src.rpm

+: good, -: fail, x: doesn't apply

+ source files match upstream:
    [ianweller@slartibartfast REVIEW]$ md5sum libtrash-3.2.tgz srpm/libtrash-3.2.tgz
    56f7b54f50d760e4719f73b98cd8b43a  libtrash-3.2.tgz
    56f7b54f50d760e4719f73b98cd8b43a  srpm/libtrash-3.2.tgz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.
+ license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present. 
+ package builds in mock.
    dist-f8, dist-f9, and dist-f10 tested on Koji
+ package installs properly.
+ debuginfo package looks complete.
+ rpmlint is silent. 
    4 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
- file permissions are appropriate.
    I'm not sure why the permissions on /etc/libtrash.conf are 444, everything
    else in that directory seems to be 644. Fix that.
+ no scriptlets present. 
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.

One remaining problem.

> [...]
> - file permissions are appropriate.
>     I'm not sure why the permissions on /etc/libtrash.conf are 444, everything
>     else in that directory seems to be 644. Fix that.

Fixed

> [...]

Spec URL: http://zprikryl.fedorapeople.org/libtrash.spec
SRPM URL: http://zprikryl.fedorapeople.org/libtrash-3.2-5.fc10.src.rpm

=== APPROVED ===

New Package CVS Request
=======================
Package Name: librash
Short Description: Libraries to move files to a trash-folder on delete
Owners: zprikryl
Branches: F-9
InitialCC: 
Cvsextras Commits: yes

I assume the package name was supposed to be libtrash?

cvs done.

libtrash-3.2-5.fc9 has been submitted as an update for Fedora 9

The name is good. Now, package is built.

libtrash-3.2-5.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.