Bug 436332

Summary: rhnpush returns 0 even if a package checksum mismatches
Product: Red Hat Satellite 5 Reporter: Daniel Mach <dmach>
Component: OtherAssignee: Pradeep Kilambi <pkilambi>
Status: CLOSED CURRENTRELEASE QA Contact: John Matthews <jmatthew>
Severity: medium Docs Contact:
Priority: medium    
Version: 510CC: bperkins, cperry, dgregor
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: sat530 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-10 20:24:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 456985    
Attachments:
Description Flags
add --strict option none

Description Daniel Mach 2008-03-06 15:47:10 UTC 
Description of problem:
When trying to push already existing package which was signed with differeny key
(quite common when pushing to testing rhn servers), rhnpush returns 0 which
indicates that everything is correct.

Version-Release number of selected component (if applicable):
rhnpush-5.1.0-8

Steps to Reproduce:
1. push rpm to rhn
2. push the same rpm signed with different key to rhn
  
Actual results:
push finishes with checksum mismatch warning
return code is 0

Expected results:
return code different than 0

Additional info:
I made a patch which adds --strict option.
When rhnpush is executed, it behaves exactly the same as before until the
--strict option is used.

It will be necessary to add strict option to rhn config file as well.

strict causes that rhnpush dies on following errors:
- ERROR: Package %s on disk but not in db
- ERROR: Package checksum %s mismatch (use --force to force upload)

Unfortunately, it dies on first error. It would be great to get list of all
errors (to be able to fix them at once), but I think it's impossible without
major code change.
Comment 1 Daniel Mach 2008-03-06 15:47:10 UTC 
Created attachment 297061 [details]
add --strict option
Comment 5 Brandon Perkins 2009-09-10 20:24:24 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2009-1434.html