Bug 436358

Summary: ctest gets NightlyStartTime value wrong
Product: [Fedora] Fedora Reporter: Frank Sweetser <fs>
Component: cmakeAssignee: Orion Poplawski <orion>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 8CC: pertusus
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.4.8-2.fc8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-06-26 08:31:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Sample report with incorrect BuildStamp
none
ctest 2.4.8 on fedora with incorrect buildstamp
none
ctest 2.4.8 on freebsd with correct buildstamp
none
ctest dashboard configuration
none
ctest -V -D Nightly output none

Description Frank Sweetser 2008-03-06 19:04:45 UTC
When you tell ctest to perform a Nightly test (-D Nightly), it is supposed to
use the NightlyStartTime parameter in the DartConfiguration.tcl file to
normalize the start times, to ensure that all nightly runs get submitted to the
dashboard with a consistent time.  Specifically, the reported time is supposed
to be set to the most recently occurring instance of NightlyStartTime.

So, for example, if NightlyStartTime is set to 9pm EST, and a build was started
at 1am EST on a Wednesday, the build should be reported to the dashboard with an
official start time of 9pm Tuesday.

Instead, what is happening is the build timestamp is being set to a value of
23:59 GMT, or 18:59 EST.  I've attached a sample output XML file from such a
run, with NightlyStartTime set to '21:00:00 EST', but I've tried numerous other
values (both different time values and different timezones, including GMT). 
Regardless of how I configure it, the BuildStamp element always has a time value
of 23:59 UTC.

This is with cmake-2.4.7-3.fc8

Comment 1 Frank Sweetser 2008-03-06 19:04:45 UTC
Created attachment 297086 [details]
Sample report with incorrect BuildStamp

Comment 2 Orion Poplawski 2008-03-06 19:09:00 UTC
Please test with 2.4.8 that has just been pushed.  If it is still a problem,
this really needs to get reported upstream.

Comment 3 Frank Sweetser 2008-03-06 19:14:45 UTC
Will do - is this update in fedora 8 updates, or should I grab the build from
fedora 9 alpha?

Comment 4 Orion Poplawski 2008-03-06 20:04:11 UTC
F8 updates - just got released today.

Comment 5 Frank Sweetser 2008-03-07 03:55:27 UTC
Okay, I installed cmake-2.4.8-1.fc8 and tried again.  The results were identical.

In addition, I was able to get a sample XML results file from another user,
using ctest 2.4.8 on FreeBSD, and identical configuration files.  On that
system, the BuildStamp value was generated correctly.

Comment 6 Frank Sweetser 2008-03-07 03:56:35 UTC
Created attachment 297138 [details]
ctest 2.4.8 on fedora with incorrect buildstamp

Comment 7 Frank Sweetser 2008-03-07 03:57:09 UTC
Created attachment 297139 [details]
ctest 2.4.8 on freebsd with correct buildstamp

Comment 8 Orion Poplawski 2008-03-07 17:44:23 UTC
I'm afraid I have no experience with ctest -D and Dart.  Could you attach a
sample DartConfiguration.tcl?

Comment 9 Frank Sweetser 2008-03-07 18:11:39 UTC
Sure.  The simplest way to generate a file is

ctest -D NightlyConfigure

The output files will be created as Testing/<build stamp>/*.xml

Comment 10 Frank Sweetser 2008-03-07 18:12:50 UTC
Created attachment 297234 [details]
ctest dashboard configuration

Comment 11 Orion Poplawski 2008-03-13 15:42:18 UTC
According to the cmake folks, the directory this is run in needs to be a CVS/svn
checked out directory.  Is that the case?  Can you attach the output of "ctest
-V -D Nightly"?

Comment 12 Frank Sweetser 2008-03-13 16:00:24 UTC
Created attachment 297951 [details]
ctest -V -D Nightly output

Comment 13 Frank Sweetser 2008-03-13 16:53:21 UTC
Just to clarify, you can see the problem in these lines:

Determine Nightly Start Time
   Specified time: 21:00:00 EST
Create new tag: 20080312-2359 - Nightly

The nightly start time of 21:00:00 EST matches the config file, but the tag is
then generated with a timestamp that doesn't match.

Comment 14 Orion Poplawski 2008-06-05 20:17:37 UTC
Upstream bug: http://public.kitware.com/Bug/view.php?id=6583

Comment 15 Fedora Update System 2008-06-06 07:49:01 UTC
cmake-2.4.8-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cmake'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-5015

Comment 16 Frank Sweetser 2008-06-06 12:29:00 UTC
That version fixes the problem for me.

Thanks!

Comment 17 Fedora Update System 2008-06-26 08:31:37 UTC
cmake-2.4.8-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.