Bug 436619
| Summary: | Review Request: bibus - Bibliographic and reference management software | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alex Lancaster <alex> |
| Component: | Package Review | Assignee: | Pierre-Yves <pingoufc4> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | pingoufc4:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-16 22:16:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alex Lancaster
2008-03-08 13:49:27 UTC
Successful koji build for F-9 here: http://koji.fedoraproject.org/koji/taskinfo?taskID=503055 Updated Requires: sqlite: http://alexlan.fedorapeople.org/reviews/bibus.spec http://alexlan.fedorapeople.org/reviews/bibus-1.4.1-2.fc8.src.rpm MUST =>rpmlint bibus.noarch: W: symlink-should-be-relative /usr/bin/bibus /usr/share/bibus/bibusStart.py * Name OK * Spec name OK => Package Guidelines: NOTOK The desktop-file-install according to http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6 If upstream uses <vendor_id>, leave it intact, otherwise use fedora as <vendor_id>. * License OK * Doc OK * English OK * Sources OK: 22b91fb9daf1e002e521e6315ade7b28 Desktop/bibus_1.4.1-1.tar.gz 22b91fb9daf1e002e521e6315ade7b28 rpmbuild/SOURCES/bibus_1.4.1-1.tar.gz * Build OK on Fedora 8 x64_86 and Fedora 8 i386 (rpmbuild and mock for both arch) * Installs and works OK * Local properly handle OK * Directory OK * %file duplicate -> none OK * Permission OK * Clean section OK => MUST: Packages containing GUI applications must include a %{name}.desktop NOTOK => MUST: Packages must not own files or directories already owned by other packages.NOTOK %{_datadir}/applications/* %{_datadir}/icons/hicolor/48x48/apps/* %{_mandir}/man1/* Should be changed to %{_datadir}/applications/%{name}.desktop %{_datadir}/icons/hicolor/48x48/apps/%{name}.png %{_mandir}/man1/%{name}.1.gz *UTF-8 OK Few questions on the file management else it looks ok :) If you can get those changes to upstream this will definitively be easier to maintain. * Thu Mar 13 2008 Alex Lancaster <alexlan[AT]fedoraproject org> - 1.4.1-3 - Fix desktop-file-install as per review (#436619) http://alexlan.fedorapeople.org/reviews/bibus.spec http://alexlan.fedorapeople.org/reviews/bibus-1.4.1-3.fc8.src.rpm There is one Requires missing: python-sqlite2 So please do not forget it before import ;) ok the only point left is the complaint for the symlink from rpmlint, since it is not a major issue and does not cause trouble to use the soft. APPROVED New Package CVS Request
=======================
Package Name: bibus
Short Description: Bibliographic and reference management software
Owners: alexlan
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes
*
cvs done. bibus-1.4.1-4.fc8 has been submitted as an update for Fedora 8 bibus-1.4.1-4.fc7 has been submitted as an update for Fedora 7 bibus-1.4.1-4.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. bibus-1.4.1-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Built and available in F-7, F-8 and will be available in rawhide once freeze is lifted. Closing bug. |