Bug 436754
| Summary: | Review Request: perl-Algorithm-FastPermute - Rapid generation of permutations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Milos Jakubicek <xjakub> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-04-05 10:00:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Milos Jakubicek
2008-03-10 09:46:02 UTC
Builds fine and rpmlint is silent. I don't understand where you see the clarified Artistic license in the upstream source. The copyright information says: This module is free software. It may be used, redistributed and/or modified under the same terms as Perl itself. which would be "GPL+ or Artistic". Do you have some other source of licensing information for this software? * source files match upstream: 20b08432ac1aebaa2cf290e92344ae19073da6d87be464952a2a73f9718890f9 Algorithm-FastPermute-0.999.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field does not seem to match the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: FastPermute.so()(64bit) perl(Algorithm::FastPermute) = 0.999 perl-Algorithm-FastPermute = 0.999-1.fc9 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. "This module is free software. It may be used, redistributed and/or modified under the same terms as Perl itself." => therefore I've followed http://dev.perl.org/licenses/, where is a note from Larry Wall: "For those of you that choose to use the GNU General Public License, my interpretation of the GNU General Public License is that no Perl script falls under the terms of the GPL unless you explicitly put said script under the terms of the GPL yourself." Anyway I've corrected it to "GPL+ or Artistic" as you and our Perl Packaging Guidelines suggest:) New SPEC: http://www.fi.muni.cz/~xjakub/perl-Algorithm-FastPermute/perl-Algorithm-FastPermute.spec New SRPM: http://www.fi.muni.cz/~xjakub/perl-Algorithm-FastPermute/perl-Algorithm-FastPermute-0.999-2.fc8.src.rpm Looks good to me. APPROVED New Package CVS Request ======================= Package Name: perl-Algorithm-FastPermute Short Description: Rapid generation of permutations Owners: mjakubicek Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Package Change Request ====================== Package Name: perl-Algorithm-FastPermute New Branches: EL-5 cvs done. |