Bug 436777
| Summary: | Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pfrields |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-31 11:12:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Luke Macken
2008-03-10 12:50:14 UTC
got build error ImportError: No module named cherrypy koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=510156 also rpmlint complained => python-tgcaptcha.src: E: description-line-too-long TGCaptcha is a TurboGears widget that provides an easy way to incorporate a captcha as part a form in an attempt to reduce spam or malicious activity. python-tgcaptcha.i386: E: script-without-shebang /usr/lib/python2.5/site-packages/tgcaptcha/static/fonts/tuffy/LICENSE.txt python-tgcaptcha.i386: E: no-binary The build issue should be fixed thanks to the following patch that I just applied to TurboGears in devel: http://cvs.fedoraproject.org/viewcvs/devel/TurboGears/TurboGears-1.0.4.4-cherrypyreq.patch?view=markup * Tue Mar 11 2008 Luke Macken <lmacken> 0.11-2 - Make package noarch - Fix lengthy description - Remove the executable bit from the fonts http://lmacken.fedorapeople.org/rpms/python-tgcaptcha-0.11-2.fc8.src.rpm http://lmacken.fedorapeople.org/rpms/python-tgcaptcha.spec Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=512432 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 08e52f7055d2f1084d225d910f637420 TGCaptcha-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. Also, 1)remove BR:python as python-devel anyway pulls it. APPROVED. New Package CVS Request ======================= Package Name: python-tgcaptcha Short Description: A TurboGears CAPTCHA widget for forms Owners: lmacken Branches: EL-5 F-7 F-8 Cvsextras Commits: Yes cvs done. almost more than 15 days passed. Is this built for requested branches so that we can CLOSE this review? Ah, yes. This has been built and releases as updates for F-7 and F-8. Thanks! |