Bug 436831
| Summary: | Review Request: gbrainy - Gbrainy is a brain teaser game and trainer to keep your brain trained | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benoît Marcelin <sereinity> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lokthare, mtasaka, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-08 17:49:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Benoît Marcelin
2008-03-10 18:24:30 UTC
*** Bug 330831 has been marked as a duplicate of this bug. *** Update to 0.61 : SPEC URL: http://sereinity.free.fr/fedora/gbrainy.spec SRPM URL: http://sereinity.free.fr/fedora/gbrainy-0.61-1.fc8.src.rpm New release : SPEC URL: http://sereinity.free.fr/fedora/gbrainy.spec SRPM URL: http://sereinity.free.fr/fedora/gbrainy-0.61-2.fc8.src.rpm Another ... SPEC URL: http://sereinity.free.fr/fedora/gbrainy.spec SRPM URL: http://sereinity.free.fr/fedora/gbrainy-0.61-4.fc8.src.rpm REVIEW :
- rpmlint output 2 errors. Seems ok for mono.
gbrainy.x86_64: E: no-binary
gbrainy.x86_64: E: only-non-binary-in-usr-lib
- The package is named according to the Package Naming Guidelines
- The spec file name match the base package
- The package meet the Packaging Guidelines
- The package is licensed with a Fedora approved license
- The License field in the package spec file match the actual license (GPLv2)
- the text of the license(s) for the package is included in %doc.
- The spec file for the package is be legible.
- The sources used to build the package match the upstream source
9e85c503475f04955e48e1b2728700f4 gbrainy-0.61.tar.gz
- successfully compile and build into binary rpms (F8 i386 + x86_64)
- ExcludeArch : ppc64
- BuildRequires ok
- locales ok
- no shared libs
- no duplicate files in the %files
- Permissions on files are set properly
- %clean section
- consistently use macros
- contain code
- no Large documentation
- %doc don't affect the runtime of the application
- no header / library
- include a %{name}.desktop
- don't own files or directories already owned by other packages
- %install, start with rm -rf %{buildroot}
- filenames in rpm packages are valid UTF-8.
- works fine (except i never find the answer, must be a bug)
- build in mock (F8, i386)
APPROVED
Remember to file a bug against Bug #238953 (ExcludeArch Tracker for ppc64)
New Package CVS Request ======================= Package Name: gbrainy Short Description: gbrainy is a brain teaser game and trainer to have fun and to keep your brain trained. Owners: sereinit Branches: F-7 F-8 InitialCC: none Cvsextras Commits: yes cvs done. A few comments: - License seems GPLv2+. - Please fix directory ownership issue (%_libdir/%name is not owned by any packages) Benoît, has Mamoru's suggestions from comment #8 been fixed? Also, it looks like this package has been built, if so this bug can be closed. |