Bug 437046
| Summary: | Review Request: mod_bw - Bandwidth Limiter For Apache | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jakub Hrozek <jhrozek> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.8-1.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-11 23:33:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jakub Hrozek
2008-03-11 21:13:53 UTC
Not sure why this hasn't been reviewed yet; it's a trivial package. * source files match upstream: 75d43f586b7662ccca7d67bc67c52e25a341c6caef89a4804fedbeaee25a13b3 mod_bw-0.8.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: config(mod_bw) = 0.8-1.fc9 mod_bw.so()(64bit) mod_bw = 0.8-1.fc9 = config(mod_bw) = 0.8-1.fc9 httpd * %check is not present; no test suite upstream. I can't easily test this. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED New Package CVS Request ======================= Package Name: mod_bw Short Description: Bandwidth Limiter For Apache Owners: jhrozek Branches: F-8 F-9 InitialCC: N/A Cvsextras Commits: yes Thanks for the review, Tibbs! cvs done. Would you consider maintaining or allowing someone else to maintain EPEL branches of this package. I could be very useful in EPEL. (In reply to comment #4) > Would you consider maintaining or allowing someone else to maintain EPEL > branches of this package. I could be very useful in EPEL. OK, I'm not planning to use the package on my CentOS box myself but I agree that it might be useful. I'll maintain it myself for EL-5 since the codebase is pretty slow target anyway. Thanks for the reminder! Package Change Request ====================== Package Name: mod_bw New Branches: EL-5 Thanks. cvs done. mod_bw-0.8-1.fc8 has been submitted as an update for Fedora 8 mod_bw-0.8-1.fc9 has been submitted as an update for Fedora 9 Built for rawhide, F-9-testing, F-8-testing and EL-5-testing. Closing. mod_bw-0.8-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. mod_bw-0.8-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |