Bug 437052
Summary: | Review Request: xgridfit - Font hinting tool | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicolas Mailhot <nicolas.mailhot> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, fonts-bugs, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-03-13 07:07:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nicolas Mailhot
2008-03-11 21:47:48 UTC
xgridfit is just a bunch of shell files and xslt filter files, and as such should be easy to review I don't think this package contains a lot of documentation to have separate -doc subpackage. Can you merge -doc to main package? (In reply to comment #2) > I don't think this package contains a lot of documentation to have separate -doc > subpackage. Can you merge -doc to main package? Are you sure? The documentation is still half the package size, and the debian maintainer chose to split it too IIRC Otherwise, un-splitting is dead easy as you know Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=512207 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 78a322021939e81cb3e2a04a306ed60b xgridfit-1-5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present in -doc subpackage. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Also, you should change Group for -doc to Documentation as given at http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b APPROVED. (In reply to comment #4) > Also, you should change Group for -doc to Documentation as given at > http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b Ok, will fix it at CVS import time. Thanks a lot for the lighting-fast review! New Package CVS Request ======================= Package Name: xgridfit Short Description: Font hinting tool Owners: nim Branches: F-8 InitialCC: fonts-sig Cvsextras Commits: yes cvs done. Thanks xgridfit-1.5-1.fc8 has been submitted as an update for Fedora 8 |