Bug 437145
| Summary: | Improper open calls open("/dev/null", 3) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eric Paris <eparis> |
| Component: | mdadm | Assignee: | Doug Ledford <dledford> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 9 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-11-19 14:47:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Changing version to '9' as part of upcoming Fedora 9 GA. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping mdadm-2.6.7-1.fc9 has been submitted as an update for Fedora 9 mdadm-2.6.7-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mdadm'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-5804 mdadm-2.6.7.1-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/mdadm-2.6.7.1-1.fc9 mdadm-2.6.7.1-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update mdadm'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9325 mdadm-2.6.7.1-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |
In the function Monitor() inside Monitor.c I see the line: open("/dev/null", 3); But 3 is not a valid open flag. O_RDONLY == 0 O_WRONLY == 1 O_RDWR == 2 For code correctness and portability I think it would be best if this was changed to use O_RDWR rather than the invalid value "3"