Bug 437321

Summary:	Review Request: libarchive - A library for handling streaming archive formats
Product:	[Fedora] Fedora	Reporter:	Tomáš Bžatek <tbzatek>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, terje.rosten, tsmetana
Target Milestone:	---	Flags:	mclasen: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-03-19 09:29:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomáš Bžatek 2008-03-13 15:25:27 UTC

Spec URL: http://tbzatek.fedorapeople.org/libarchive/libarchive.spec
SRPM URL: http://tbzatek.fedorapeople.org/libarchive/libarchive-2.4.13-1.fc9.src.rpm

Description: 
Libarchive is a programming library that can create and read several different
streaming archive formats, including most popular tar variants, several cpio
formats, and both BSD and GNU ar variants. It can also write shar archives and
read ISO9660 CDROM images and ZIP archives.

Comment 1 Matthias Clasen 2008-03-14 23:43:35 UTC

rpmlint says:

libarchive.i386: W: no-documentation

and it is right, COPYING, README and NEWS should go into %doc

Comment 2 Matthias Clasen 2008-03-15 01:10:51 UTC

rpmlint: has been run, see above
package name: ok
spec file name: ok
packaging guidelines: met
license: ok
license field: ok
license file: must be included, see above
spec file language: ok
spec file clarity: very clear
source: ok
builds: yes
excludearch: n/a
buildrequires: ok
locale handling: n/a
shared libs: ok
relocatable: n/a
directory ownership: ok
%file: ok
permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc: ok, but missing some files, see above
headers: ok
static libs: n/a
pkgconfig files: n/a
shared libs: ok
devel package: ok
libtool archives: ok
gui apps: n/a
file ownership: ok
%install: ok
utf-8 filenames: ok


Summary: include the missing %doc files, and the package is ready to go

Comment 3 Tomáš Bžatek 2008-03-18 10:35:57 UTC

Uploaded new spec and srpm:
Spec URL: http://tbzatek.fedorapeople.org/libarchive/libarchive.spec
SRPM URL: http://tbzatek.fedorapeople.org/libarchive/libarchive-2.4.14-1.fc9.src.rpm

- docs are now included
- rebased to 2.4.14

rpmlint now reports no error, please check

Comment 4 Matthias Clasen 2008-03-18 12:41:36 UTC

Looks fine now. Approved.

Comment 5 Tomáš Bžatek 2008-03-18 13:15:50 UTC

New Package CVS Request
=======================
Package Name: libarchive
Short Description: A library for handling streaming archive formats
Owners: tbzatek
Branches: devel
InitialCC: tbzatek
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-03-18 17:26:25 UTC

cvs done.

Comment 7 Tomáš Bžatek 2008-03-19 09:29:10 UTC

Thanks! Successfully built for dist-f9.
Closing.

Comment 8 Terje Røsten 2009-02-27 18:40:56 UTC

Why is --disable-bsdtar used? bsdtar has some nice features.

I can help creating the bsdtar subpackage if you want.

Comment 9 Tomáš Bžatek 2011-02-22 14:20:22 UTC

Package Change Request
======================
Package Name: libarchive
New Branches: el5
Owners: tbzatek
InitialCC: devos

Comment 10 Jason Tibbitts 2011-02-22 17:10:14 UTC

Git done (by process-git-requests).