Bug 437465

Summary: "dos2unix -n" creates files with overly restrictive permissions
Product: Red Hat Enterprise Linux 5 Reporter: john.haxby <john.haxby>
Component: dos2unixAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 5.1CC: psplicha, rkhadgar, sghosh
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 531928 (view as bug list) Environment:
Last Closed: 2009-02-11 14:28:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 531928    
Attachments:
Description Flags
Proposed Patch none

Description john.haxby@oracle.com 2008-03-14 12:00:11 UTC 
Description of problem:

"dos2unix -n" creates its new file with an overly restrictive mode: in fact the
new file is always created with mode 600.  This differs from "dos2unix -a" where
the mode of the file is retained and "cp" which keeps the source file mode,
modulo the umask.

Version-Release number of selected component (if applicable): 3.1-21.2 (also
present in several other versions, including those on RHEL4 and Fedora8)


How reproducible: always




Steps to Reproduce:
1.  touch xxx
2.  dos2unix -n xxx yyy
3.  ls -l xxx yyy
  
Actual results:

Assuming your umask is 002, xxx has permissions 664 but yyy has permissions 600

Expected results:

yyy should have the same permissions as xxx (modulo the umask)


Additional info:

I would expect similar permissions to those obtained from "cp xxx yyy"   The
attached patch does exactly that: the temporary file created for the conversion
has its permissions change to match the source file with the bits from the
current umask masked off.
Comment 1 john.haxby@oracle.com 2008-03-14 12:00:11 UTC 
Created attachment 298043 [details]
Proposed Patch
Comment 2 john.haxby@oracle.com 2008-03-14 12:01:03 UTC 
The same patch can be applied to dos2unix from both RHEL4 and Fedora8
Comment 3 Tim Waugh 2008-03-14 12:14:54 UTC 
Thanks for the patch.
Comment 4 john.haxby@oracle.com 2008-03-14 13:14:49 UTC 
See also 437469
Comment 6 Phil Knirsch 2008-04-30 15:52:09 UTC 
Proposing for RHEL-5.3 and granting Devel ACK.

Read ya, Phil
Comment 7 Tim Waugh 2008-05-06 09:04:21 UTC 
If bug #437469 is a FasTrack candidate, this bug should be as well.
Comment 8 Phil Knirsch 2008-05-14 14:18:26 UTC 
As per comment #7 proposing bug for RHEL-5.3 FasTrack.

Read ya, Phil
Comment 11 RHEL Program Management 2008-06-23 21:08:02 UTC 
This bugzilla was reviewed by QE as a non-FasTrack request.
It has since been proposed for FasTrack. The qa_ack has 
been reset. QE needs to re-review this bugzilla for FasTrack.
Comment 17 errata-xmlrpc 2009-02-11 14:28:53 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0276.html