Bug 437514

Summary: virt-manager needs to trim input text
Product: Red Hat Enterprise Linux 5 Reporter: Paul Batkowski <pbatkowski>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.2CC: gozen, pbatkowski, xen-maint
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-20 21:20:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 449772    
Attachments:
Description Flags
proposed patch to trim input text for installation media and kickstart url none

Description Paul Batkowski 2008-03-14 17:19:57 UTC 
Description of problem:

Virt-manager does not trim the input text for the installation location or
kickstart location. When specifying an install location that contains a " "
(space) before the url, virt-manager detects it as an incorrect location and
fails to allow the user to proceed. This text should be trimmed of whitespace
before and after.

Version-Release number of selected component (if applicable):

virt-manager-0.5.3-4.el5

How reproducible:

Always

Steps to Reproduce:
1. Input the following installation location: "
http://satellite.example.com/kickstart/ks/label/rhel51-x86_64-base"
2. Note the " " whitespace in front of the URL.
  
Actual results:

Virt-manager complains with error message stating:

"""Kickstart URL Error

Kickstart location must be an NFS, HTTP or FTP source"""

Same is true for the Installation Location URL.

Expected results:

virt-manager trims the input text.

Additional info:

Attaching a simple proposed patch.
Comment 1 Paul Batkowski 2008-03-14 17:19:57 UTC 
Created attachment 298072 [details]
proposed patch to trim input text for installation media and kickstart url
Comment 2 Cole Robinson 2008-04-08 21:01:41 UTC 
Hi, I've committed this upstream:

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=4469eb7b8f26

But its not high enough priority to pull it into 5.2 at this stage. We can
certainly pull it in for 5.3 though. Thanks!
Comment 4 RHEL Program Management 2008-06-24 01:32:29 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 5 Cole Robinson 2008-09-15 16:06:11 UTC 
Okay, this should be fixed in virt-manager-0.5.3-9.el5. Setting bug to MODIFIED.
Comment 8 errata-xmlrpc 2009-01-20 21:20:41 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0137.html