Bug 437658

Summary:	Review Request: python-ply - Python Lex-Yacc
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <tcallawa>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	panemade: fedora-review+ tcallawa: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-03-25 00:22:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom "spot" Callaway 2008-03-15 20:46:59 UTC

Spec URL: http://www.auroralinux.org/people/spot/review/new/python-ply.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/python-ply-2.3-1.fc9.src.rpm
Description: 
PLY is a straightforward lex/yacc implementation. Here is a list of its
essential features:
* It is implemented entirely in Python.
* It uses LR-parsing which is reasonably efficient and well suited for larger
  grammars.
* PLY provides most of the standard lex/yacc features including support
  for empty productions, precedence rules, error recovery, and support
  for ambiguous grammars.
* PLY is straightforward to use and provides very extensive error checking.
* PLY doesn't try to do anything more or less than provide the basic lex/yacc
  functionality. In other words, it's not a large parsing framework or a
  component of some larger system.

Comment 1 Parag AN(पराग) 2008-03-17 04:03:33 UTC

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=519008
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
e406e5eef98661d395d901f8cc3d1219  ply-2.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Suggestions:
   You can add examples directory as %doc.

APPROVED.

Comment 2 Parag AN(पराग) 2008-03-24 11:41:13 UTC

ping?

Comment 3 Tom "spot" Callaway 2008-03-24 21:24:40 UTC

Package Name: python-ply
Short Description: Python Lex-Yacc
Owners: spot
Branches: F-7 F-8 EL-4 EL-5
InitialCC: 
Cvsextras Commits: yes

Comment 4 Tom "spot" Callaway 2008-03-24 21:30:53 UTC

cvs done.

Comment 5 Tom "spot" Callaway 2008-03-25 00:22:17 UTC

Committed and built, thanks for the review.