Bug 437924 (perl-Template-Timer)

Summary: Review Request: perl-Template-Timer - Template::Timer Perl module
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, iarnell, notting
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Template-Timer/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-03-18 20:07:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 438083    

Description Chris Weyl 2008-03-18 07:08:55 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Template-Timer-0.04-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Template-Timer.spec

Description:
Template::Timer provides inline timings of the template processing
througout your code.  It's an overridden version of Template::Context that
wraps the process() and include() methods.

Comment 1 Chris Weyl 2008-03-18 07:09:44 UTC
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=520534

Comment 2 Parag AN(पराग) 2008-03-18 08:29:00 UTC
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=520534
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
063b7d84c5cd501a2820f9c2e601eadc  Template-Timer-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=4,  0 wallclock secs ( 0.37 cusr +  0.02 csys =  0.39 CPU)
+ Package perl-Template-Timer-0.04-1.fc9 =>
  Provides: perl(Template::Timer) = 0.04
  Requires: perl(Time::HiRes) perl(base) perl(strict) perl(warnings)

APPROVED.

Comment 3 Chris Weyl 2008-03-18 14:51:11 UTC
New Package CVS Request
=======================
Package Name: perl-Template-Timer
Short Description: Template::Timer Perl module
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2008-03-18 17:39:12 UTC
cvs done.

Comment 5 Chris Weyl 2008-03-18 20:07:14 UTC
Thanks for the review!

Comment 6 Iain Arnell 2010-09-02 14:36:36 UTC
Package Change Request
======================
Package Name: perl-Template-Timer
New Branches: el6
Owners: iarnell tremble

Comment 7 Kevin Fenzi 2010-09-02 21:20:23 UTC
Git done (by process-git-requests).