Bug 438024
| Summary: | Review Request: freeimage - Multi-format image decoder library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, hobbes1069, john, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-27 12:39:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 435399 | ||
|
Description
Hans de Goede
2008-03-18 18:32:33 UTC
I'll review it. REVIEW:
+ rpmlint is silent.
+ The package named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package licensed with a Fedora approved license and meet the Licensing
Guidelines.
+ The License field in the package spec matches the actual license.
+ The spec file written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package must matches the upstream source.
[petro@Sulaco SOURCES]$ md5sum FreeImage3100.zip*
2e57135e26bb487cc8e13ee7b7e0a595 FreeImage3100.zip
2e57135e26bb487cc8e13ee7b7e0a595 FreeImage3100.zip.1
[petro@Sulaco SOURCES]$
+ The package must successfully compiles and builds into binary rpms on ppc
architecture.
+ All build dependencies listed in BuildRequires.
+ Every binary RPM package which stores shared library files (not just symlinks)
in any of the dynamic linker's default paths, must call ldconfig in %post and
%postun. If the package has multiple subpackages with libraries, each subpackage
should also have a %post/%postun section that calls /sbin/ldconfig. An example
of the correct syntax for this is:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ Each package must consistently use macros, as described in the macros section
of Packaging Guidelines.
+ The package contain code, or permissable content.
+ If a package includes something as %doc, it must not affect the runtime of the
application.
+ Header files are in a -devel package.
+ If a package contains library files with a suffix (e.g. libfoo.so.1.1), then
library files that end in .so (without suffix) must go in a -devel package.
+ In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
+ Packages does NOT contain any .la libtool archives.
+ Packages does not own files or directories already owned by other packages.
+ At the beginning of %install, package run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
APPROVED.
Thanks for the review! New Package CVS Request ======================= Package Name: freeimage Short Description: Multi-format image decoder library Owners: jwrdegoede Branches: F-8 InitialCC: Cvsextras Commits: Yes cvs done. Imported and build, closing. Package Change Request ====================== Package Name: freeimage New Branches: el6 Owners: hobbes1069 zultron InitialCC: Need for FreeCAD in RPM Fusion. Git done (by process-git-requests). Package Change Request ====================== Package Name: freeimage New Branches: epel7 Owners: hobbes1069 zultron InitialCC: Git done (by process-git-requests). |