Bug 438083
| Summary: | Review Request: perl-Catalyst-View-TT - Template Toolkit View Class | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Catalyst-View-TT/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-03-19 19:40:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 437924 | ||
| Bug Blocks: | |||
|
Description
Chris Weyl
2008-03-18 21:56:15 UTC
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=521583 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 653f58f818a1b0b3d0ad28b62c13241b Catalyst-View-TT-0.26.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=8, Tests=38, 1 wallclock secs ( 1.50 cusr + 0.21 csys = 1.71 CPU) + Package perl-Catalyst-View-TT-0.26-1.fc9 => Provides: perl(Catalyst::Helper::View::TT) perl(Catalyst::Helper::View::TTSite) perl(Catalyst::View::TT) = 0.26 Requires: perl(Catalyst) perl(Data::Dump) perl(File::Spec) perl(NEXT) perl(Path::Class) perl(Template) perl(Template::Timer) perl(base) perl(strict) perl(warnings) APPROVED. New Package CVS Request ======================= Package Name: perl-Catalyst-View-TT Short Description: Template Toolkit View Class Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig cvs done. Thanks for the review! Package Change Request ====================== Package Name: perl-Catalyst-View-TT New Branches: el6 Owners: iarnell tremble Git done (by process-git-requests). |