Bug 438195
Summary: | Review Request: wgrib2 - Manipulate, inventory and decode GRIB2 files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, pertusus |
Target Milestone: | --- | Flags: | pertusus:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-20 15:43:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Orion Poplawski
2008-03-19 17:10:25 UTC
I did a package too, very similar with yours (strange isn't it ;-) but with a makefile patch different and correspondingly a make call slightly different. Otherwise I think that the first paragraph of the %description would be enough. Also I have a libpng-devel BuildRequires And this for the license: # most files are public domain, geo.c and Netcdf.c are GPL+, gribtab.c is GPLv2+ License: GPLv2+ and summary Summary: Manipulate, inventory and decode GRIB2 files http://www.environnement.ens.fr/perso/dumas/fc-srpms/wgrib2-pat.spec http://www.environnement.ens.fr/perso/dumas/fc-srpms/wgrib2-1.6.1-1.fc9.src.rpm (In reply to comment #1) > I did a package too, very similar with yours (strange isn't it ;-) I guess we both work in the earth sciences area? > but with a makefile patch different and correspondingly a make > call slightly different. I've reworked mine again. > Otherwise I think that the first paragraph of the %description would > be enough. Agreed. > Also I have a libpng-devel BuildRequires g2clib-devel requires libpng-devel. > And this for the license: > # most files are public domain, geo.c and Netcdf.c are GPL+, gribtab.c is GPLv2+ > License: GPLv2+ Fixed. > and summary > Summary: Manipulate, inventory and decode GRIB2 files Fixed. http://www.cora.nwra.com/~orion/fedora/wgrib2.spec http://www.cora.nwra.com/~orion/fedora/wgrib2-1.7.2b-1.fc8.src.rpm * Mon May 19 2008 Orion Poplawski <orion.com> - 1.7.2b-1 - Update to 1.7.2b - Update makefile patch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=617750 (In reply to comment #2) > (In reply to comment #1) > > I did a package too, very similar with yours (strange isn't it ;-) > > I guess we both work in the earth sciences area? As strange as it may be, I am not in earth sciences (though I was trained as a biologist), I am an economist, but an economist working a lot with climate scientists (mainly on climate change consequences)... > g2clib-devel requires libpng-devel. Ok. I have 2 remarks - I think it is better to avoid naming files with fedora, to play nicer with downstream for spec files, be it only EPEL. - the -r of rm is useless These are not blockers, so: * follow packaging guidelines * match upstream 8929dd70291298b2638a6740011d82be wgrib2.tgz.v1.7.2b * free software, license included * %files section right APPROVED I'd appreciate to be in initialCC and watchcommit. New Package CVS Request ======================= Package Name: wgrib2 Short Description: Manipulate, inventory and decode GRIB2 files Owners: orion Branches: F-9 F-8 F-7 EL-5 EL-4 InitialCC: pertusus WatchCommit: pertusus Cvsextras Commits: yes cvs done, with the exception of the watchcommits. You will need to request that from the package database webpage. Checked in, built, added to f10 comps. |