Bug 438445

Summary:	Review Request: python-cjson - Fast JSON encoder/decoder for Python
Product:	[Fedora] Fedora	Reporter:	Toshio Ernie Kuratomi <a.badger>
Component:	Package Review	Assignee:	Tim Lauridsen <tim.lauridsen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	tim.lauridsen: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-04-08 00:41:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Toshio Ernie Kuratomi 2008-03-20 22:04:38 UTC

Spec URL: http://toshio.fedorapeople.org/packages/python-cjson.spec
SRPM URL: http://toshio.fedorapeople.org/packages/python-cjson-1.0.5-1.fc8.src.rpm
Description:
JSON stands for JavaScript Object Notation and is a text based lightweight
data exchange format which is easy for humans to read/write and for machines
to parse/generate. JSON is completely language independent and has multiple
implementations in most of the programming languages, making it ideal for
data exchange and storage.

The module is written in C and it is up to 250 times faster when compared to
the other python JSON implementations which are written directly in python.
This speed gain varies with the complexity of the data and the operation and
is the the range of 10-200 times for encoding operations and in the range of
100-250 times for decoding operations.

Comment 1 Tim Lauridsen 2008-03-25 09:42:29 UTC

rpmlint silent on rpm & srpm

Comment 2 Tim Lauridsen 2008-03-25 09:54:05 UTC

MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* verify source and patches (md5sum matches upstream, know what the patches do)
4d55b66ecdf0300313af9d030d9644a3 python-cjson-1.0.5.tar.gz
* summary and description fine
* correct buildroot
* %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86_64
* BuildRequires are proper
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* no config files
* not a GUI app
* no -devel sub-package necessary
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locale data
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* file permissions fine
* %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime

APPROVED

Comment 3 Tim Lauridsen 2008-03-25 09:58:40 UTC

UPS, missed something

BuildRequires:  python-setuptools-devel

should be added.

Comment 4 Toshio Ernie Kuratomi 2008-03-25 16:15:37 UTC

(In reply to comment #3)
> UPS, missed something
> 
> BuildRequires:  python-setuptools-devel
> 
> should be added.

This package only uses distutils in its setup.py, not setuptools.  Why is
setuptools-devel a necessary BuildRequires?

Comment 5 Tim Lauridsen 2008-03-25 16:30:57 UTC

My mistake, please ignore it.

Comment 6 Toshio Ernie Kuratomi 2008-04-06 05:58:45 UTC

New Package CVS Request
=======================
Package Name: python-cjson
Short Description: Fast JSON encoder/decoder for Python
Owners: toshio
Branches: F-8 EL-5 devel
InitialCC: 
Cvsextras Commits: yes

Comment 7 Kevin Fenzi 2008-04-07 22:09:51 UTC

cvs done.

Comment 8 Toshio Ernie Kuratomi 2008-04-08 00:41:48 UTC

Packages committed and built.