Bug 438806
| Summary: | Review Request: php-pear-HTTP-Header - OO interface to modify and handle HTTP headers and status codes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Hollis <dhollis> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, notting, pahan |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-03-01 08:22:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 438810 | ||
|
Description
David Hollis
2008-03-25 12:50:58 UTC
I can't do a formal review as i'm not a sponsor.
Should fix the %file :
%{pear_phpdir}/HTTP
%{pear_testdir}/HTTP_Header
Note HTTP dir is not owned by php-pear-HTTP, so you need to own it.
Should requires only php-common to avoid pulling "apache" in dependencies.
Or simply remove php >= 4.2.0 which is very old.
Ok, I've made the requested changes. Spec URL: http://web.davehollis.com:81/packages/php-pear-HTTP-Header.spec SRPM URL: http://web.davehollis.com:81/packages/php-pear-HTTP-Header-1.2.0-2.fc8.src.rpm Actually, Remi is a sponsor now although I really thought someone else was going to sponsor David. I am in the process of sponsoring David with bug #438804 It's been another six weeks; has anything happened regarding sponsorship? Just waiting on sponsorship, or if someone wants to take this package under their wing, that's fine by me. * source files match upstream:
68e0a84fb3aca46e6e0a6ccfe25c2d6b HTTP_Header-1.2.0.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (BSD)
* license is open source-compatible.
* latest version is being packaged (1.2.0)
* %clean is present.
* package builds in mock (development).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
php-pear(HTTP_Header) = 1.2.0
php-pear-HTTP-Header = 1.2.0-2.fc8
* %check is not present; test suite cannot run in rpmbuild
* owns the directories it creates (HTTP already owned but by non-dependant rpm)
* doesn't own any directories it shouldn't.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Please remove the TODO comment as file list is ok.
Remove php-common from Requires as already required by pear (only need if you want to set a minimal version, which is not the case)
This 2 lines are redundant.
%dir %{pear_phpdir}/HTTP
%{pear_phpdir}/HTTP
Missing BR on dos2unix, so doesn't build in mock.
Add it or switch to sed.
ping ?? No reponse, I close this bug to allow anynody else to submit this package again. |