Bug 438932
| Summary: | Review Request: libotf - Library for handling OpenType Font | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neal Becker <ndbecker2> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-26 00:24:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Neal Becker
2008-03-26 01:03:43 UTC
1)No need of INSTALL as %doc 2)add Requires: pkgconfig to -devel package 3)Use following to preserve timestamps while installing make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 4) rpmlint gave me libotf.i386: W: devel-file-in-non-devel-package /usr/bin/libotf-config A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. ==> Good if you move file libotf-config to -devel package I believe all the above have been fixed. Please see: http://nbecker.dyndns.org:8080/RPM/libotf.spec http://nbecker.dyndns.org:8080/RPM/libotf-0.9.7-2.fc8.src.rpm Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=535524 + rpmlint is silent for SRPM and RPM. + source files match upstream. 017dc38925ffe33cc76d6d29c7757d36 libotf-0.9.7.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + libotf.pc files are present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + package libotf-0.9.7-2.fc9-> Provides: libotf.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libfreetype.so.6 libotf.so.0 rtld(GNU_HASH) + package libotf-devel-0.9.7-2.fc9 -> Requires: /bin/sh libotf.so.0 + Not a GUI app. SHOULD: 1) change license to LGPLv2+ 2) add examples directory to %doc of -devel package. 3) Source URL should be http://www.m17n.org/%{name}/%{name}-%{version}.tar.gz Please submit updated SRPM here. Updated SRPM: http://nbecker.dyndns.org:8080/RPM/libotf-0.9.7-3.fc8.src.rpm Minor: installing example also installs subdir .deps. I recommend ignoring this because removing it will break the Makefile. simple way then is to add to -devel %doc example/*.c ping for updated SRPM You mean only install example/*.c and not Makefile? I think the original (including Makefile and .deps) is better - at least it has then a working Makefile. I have not seen such case where .deps also got installed. Just search for .deps under /usr/share/doc and afaics there is no .deps there. so if you want .deps also then I will ask you to drop %doc example/*.c OK, .deps removed http://nbecker.fedorapeople.org/libotf-0.9.7-4.fc8.src.rpm sorry I thought I posted review here but it seems I need to do that yet. Will review this tomorrow. (In reply to comment #11) > sorry I thought I posted review here but it seems I need to do that yet. Will > review this tomorrow. Ping? sorry. I got so busy schedule at home and work also. will review now. koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=595436 Package looks Ok now. APPROVED. New Package CVS Request ======================= Package Name: libotf Short Description: Library for handling OpenType Font Owners: nbecker Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Neal, has this been built? If so, you can close this bug. |