Bug 439152
Summary: | Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Simon Wilkinson <simon> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | cweyl, fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-04-12 21:11:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Simon Wilkinson
2008-03-27 11:18:15 UTC
panemade pointed out a problem with another of my packages, that's also in this one - it needs to BuildRequire Test::Pod and Test::Pod::Coverage. I've done a pre-review respin to address this. SPEC URL as above, new SRPM is http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Plugin-StackTrace- 0.07-2.fc9.src.rpm Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=534017 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4bd2dc12f9b6f6bb310c1fe07a8321f1 Catalyst-Plugin-StackTrace-0.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 3 tests skipped. Files=9, Tests=24, 2 wallclock secs ( 1.88 cusr + 0.13 csys = 2.01 CPU) +Package perl-Catalyst-Plugin-StackTrace-0.07-2.fc9 => Provides: perl(Catalyst::Plugin::StackTrace) = 0.07 Requires: perl >= 0:5.008001 perl(Devel::StackTrace) perl(HTML::Entities) perl(NEXT) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) SHOULD: 1)Try adding line to enable tests in %check export TEST_POD=1 MUST: 1) Drop redundant BR BuildRequires: perl >= 1:5.8.1 APPROVED. ping? New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-StackTrace Short Description: Display a stack trace on the Catalyst debug screen Owners: sxw Branches: EL-5 F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. Thanks! |