Bug 439270

Summary: failure to select /boot terminates install
Product: Red Hat Enterprise Linux 5 Reporter: Amy Griffis <amy.griffis>
Component: anacondaAssignee: Chris Lumens <clumens>
Status: CLOSED ERRATA QA Contact: Alexander Todorov <atodorov>
Severity: medium Docs Contact:
Priority: low    
Version: 5.2CC: amy.griffis, dchapman, jlaska, martine.silbermann, rick.hester
Target Milestone: rc   
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2008-0397 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-21 15:33:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Amy Griffis 2008-03-27 19:53:53 UTC
Description of problem:
If the user fails to setup a /boot mount point before leaving
the Create Custom Layout screen, the installation terminates
with an exception.

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. for partitions, choose Create Custom Layout
2. setup the / mount point
3. do not setup a /boot mount point
4. choose [OK]
  
Actual results:

Anaconda gives the following traceback:

+--------------+ Exception Occurred +--------------+ 
|                                                  | 
| Traceback (most recent call first):            ^ |
|   File "/usr/lib/anaconda/fsset.py", line      # | 
| 2986, in getDiskPart                           : | 
|     if dev[-2] in string.digits:               : | 
|   File "/usr/lib/anaconda/partitions.py",      : | 
| line 867, in sanityCheckAllRequests            : | 
|     (dev, num) = fsset.getDiskPart(br.device)  : | 
|   File                                         : | 
| "/usr/lib/anaconda/textw/partition_text.py",   : | 
| line 1489, in __call__                         : |                           
  |     (errors, warnings) =                       : |
| self.partitions.sanityCheckAllRequests(self.d  v | 
|                                                  | 
|         +----+                +-------+          | 
|         | OK |                | Debug |          | 
|         +----+                +-------+          | 
|                                                  | 
|                                                  | 
+--------------------------------------------------+ 

Expected results:
Anaconda should allow the user to correct the problem and
continue with the install.

Additional info:

Comment 1 Chris Lumens 2008-03-28 00:45:49 UTC
Can you please attach the complete traceback to this bug report?  You can find
this in /tmp/anacdump.txt.

Comment 4 Amy Griffis 2008-03-28 21:12:09 UTC
Is there a way to get that information from the debugger?  The install fails
before it has a chance to format the root partition.

Here's a bit more seen after choosing [Debug].

 Traceback (most recent call first):
  File "/usr/lib/anaconda/fsset.py", line 2986, in getDiskPart
    if dev[-2] in string.digits:
  File "/usr/lib/anaconda/partitions.py", line 867, in sanityCheckAllRequests
    (dev, num) = fsset.getDiskPart(br.device)
  File "/usr/lib/anaconda/textw/partition_text.py", line 1489, in __call__
    (errors, warnings) = self.partitions.sanityCheckAllRequests(self.diskset)
  File "/usr/lib/anaconda/text.py", line 565, in run
    rc = win(self.screen, instance)
  File "/usr/bin/anaconda", line 982, in ?
    anaconda.intf.run(anaconda)
IndexError: string index out of range

Comment 5 Amy Griffis 2008-03-28 21:37:01 UTC
I don't know this code, but do you need to sanity check either bootreqs or
br.device before calling fsset.getDiskPart() at partitions.py: 867?

Comment 6 Chris Lumens 2008-03-31 14:05:51 UTC
There is a complete traceback report in /tmp/anacdump.txt that anaconda also
prompts you to save to a remote system when the exception occurs.  This file
contains a full dump of the state of internal anaconda variables, so we can see
things like what dev was when it tried to subscript it (though I'm guessing it
was blank or perhaps None) and other things like that.

Comment 7 Chris Lumens 2008-04-01 15:56:34 UTC
Okay, I see what's going on here and have a patch that fixes this issue.

Comment 8 Amy Griffis 2008-04-01 16:11:57 UTC
Okay good, because I don't get the prompt to save off the dump file (maybe too
early in the install?) 

Comment 10 James Laska 2008-04-01 17:35:57 UTC
VERIFIED using snap#3 and http://people.redhat.com/clumens/439270.img

* Tested removing /boot and proceeding with / as a logical volume (error dialog
properly displayed)
* Tested removing /boot and proceeding with / as ext3

Comment 12 Chris Lumens 2008-04-01 18:44:34 UTC
This will be fixed in anaconda-11.1.2.111.

Comment 16 errata-xmlrpc 2008-05-21 15:33:44 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0397.html