Bug 439337
Summary: | Review Request: python-sphinx - Python documentation generator | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> | ||||
Component: | Package Review | Assignee: | José Matos <jamatos> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | brad, fedora-package-review, jamatos, notting | ||||
Target Milestone: | --- | Flags: | jamatos:
fedora-review+
gwync: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 0.3-1.fc9 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-07-06 06:14:46 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Michel Lind
2008-03-28 03:46:02 UTC
When I attempt to build this in mock, I get: + /usr/bin/python setup.py build --------------------------------------------------------------------------- This script requires setuptools version 0.6c5 to run (even to display help). I will attempt to download it for you (from http://cheeseshop.python.org/packages/2.5/s/setuptools/), but you may need to enable firewall access for this script first. I will start the download in 15 seconds. (Note: if this machine does not have network access, please obtain the file http://cheeseshop.python.org/packages/2.5/s/setuptools/setuptools-0.6c5-py2.5.egg and place it in this directory before rerunning this script.) --------------------------------------------------------------------------- which obviously isn't going to work as mock cannot access the network. Ah, missed some builddeps there. Will fix tonight, thanks. Just to clarify, you're not officially reviewing this package, right? Added missing BR on python-setuptools: Spec URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx.spec SRPM URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx-0.1.61950-1.fc9.src.rpm Koji build (F-9): http://koji.fedoraproject.org/koji/taskinfo?taskID=564739 I can review this package if Jason does not want and/or is too busy. :-) Just for reference here it is my review: Review for release 1.fc9: * RPM name is OK * Source Sphinx-0.1.61950.tar.gz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * The license is OK (and included in the package) (30 checks have been run) It's fair game if I've not assigned the review to myself, so please go ahead. Thanks Jason. Michel the package looks OK there is a single problem: rpmlint of python-sphinx: python-sphinx.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/sphinx/jinja/_speedups.c Also IMHO you could build the documentation in the %build stage, there is a Makefile in doc where the different targets are explained. The doc directory with the rst documents is interesting by itself so I suggest to package it. I suggest something like the patch that I will place in the next entry. Created attachment 302585 [details]
Patch to include more documentation (html and rst).
Patch to include more documentation (html and rst).
Thanks Jose. Will incorporate the patch -- I should probably split it into a -doc subpackage as well. Problem fixed, documentation included and split into -doc. Thanks for the suggestion -- ready when you are, Jose. Spec URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx.spec SRPM URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx-0.1.61950-3.fc9.src.rpm I like what I see. :-) Just one other request, the new 0.3 version has been released, could you, please, update the spec file? As soon as you do that I will review and approve the package. Ah, thanks. Spec and SRPM updated: Spec URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx.spec SRPM URL: http://salimma.fedorapeople.org/for_review/python/python-sphinx-0.3-1.fc9.src.rpm Two brief notes: 1) You define %pyver but you never use it. 2) The srpm spec file still has the exclusion part while the spec you present in the entry above does not have it. Of course the spec without the exclusion is the right one. These points are minor and can be fixed later when importing. APPROVED. Thanks, %{pyver} must have been a leftover from the default spec. Will double-check when committing New Package CVS Request ======================= Package Name: python-sphinx Short Description: Python documentation generator Owners: salimma Branches: EL-5 F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Thanks. python-sphinx-0.3-1.fc9 has been submitted as an update for Fedora 9 python-sphinx-0.3-1.fc8 has been submitted as an update for Fedora 8 python-sphinx-0.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. python-sphinx-0.3-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. Dan Radez is requesting this package for EPEL 6; I've tested that python-sphinx 1.0.x works fine there. Package Change Request ====================== Package Name: python-sphinx New Branches: el6 Owners: salimma radez InitialCC: Git done (by process-git-requests). Thanks! |