Bug 439911

This failed to build for me:

+ ant jar
Buildfile: build.xml
init:
prepare-sources:
    [mkdir] Created dir: /builddir/build/BUILD/stringtemplate-3.1/build
    [mkdir] Created dir: /builddir/build/BUILD/stringtemplate-3.1/build/src
     [copy] Copying 71 files to /builddir/build/BUILD/stringtemplate-3.1/build/src
generator:
BUILD FAILED
/builddir/build/BUILD/stringtemplate-3.1/build.xml:98: Problem: failed to create
task or type antlr
Cause: the class org.apache.tools.ant.taskdefs.optional.ANTLR was not found.
        This looks like one of Ant's optional components.
Action: Check that the appropriate optional JAR exists in
        -/usr/share/ant/lib
        -/builddir/.ant/lib
        -a directory added on the command line with the -lib argument
Do not panic, this is a common problem.
The commonest cause is a missing JAR.
This is not a bug; it is a configuration problem
Total time: 0 seconds
error: Bad exit status from /var/tmp/rpm-tmp.71988 (%build)

Thanks, I cleaned up the build deps:

http://cdn.verbum.org/stringtemplate.spec
http://cdn.verbum.org/stringtemplate-3.1-1.fc9.src.rpm

Yes, much better now.  rpmlint says:

  stringtemplate.noarch: W: no-documentation
There seems to be quite a bit of documentation in the package, including some
license text.  Certainly the three .txt files need to be included, and at least
doc.html in the doc subdirectory seems to be useful as well.

  stringtemplate.noarch: W: no-version-in-last-changelog
Please follow one of the standard formats for changelog entries:
http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

I need to whip up a review template for Java; I'll get on that now.

I noticed something that looks like a test suite; it is possible to run it at
build time?

The package seems to be missing a versioned dependency on java as required by
the guidelines.

* source files match upstream:
   59fa7e74646ef4767a6d55356c580d5f24d1392ef89fbd0c435c6426353aaf7c  
   stringtemplate-3.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
X license text in tarball but not included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
X rpmlint has valid complaints.
X final provides and requires not quite correct:
   stringtemplate = 3.1-1.fc9
  =
   jpackage-utils
   (no java dependency)
? %check is not present, but there seems to be a test suite upstream.  I've no 
   idea how to run it, though.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* %docs are not necessary for the proper functioning of the package.

Java-specific bits:
* no pre-built jars
* single jar, named after the package
* jarfiles are under _javadir.

* On the tests, I just created two patches (both sent upstream).  The first adds
a convenient "ant test" target, and the second disables some of the tests which
upstream had either left broken, or as far as I could tell the test was actually
itself broken.  The vast majority of tests pass.
* Fixed license.
* Fixed requires.

New versions:
http://cdn.verbum.org/stringtemplate.spec
http://cdn.verbum.org/stringtemplate-3.1-1.fc9.src.rpm

This seems to have cropped up, or did I somehow miss it earlier:
  stringtemplate.src:42: W: rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT
Normally you don't need to erase the build root in %build, because it should be
empty before %install.  Why do you need to do that?

Otherwise, things look good:

The license text is present.
The dependencies look correct:
  stringtemplate-3.1-1.fc9.noarch.rpm
   stringtemplate = 3.1-1.fc9
  =
   java >= 1:1.6.0
   jpackage-utils

  stringtemplate-javadoc-3.1-1.fc9.noarch.rpm
   stringtemplate-javadoc = 3.1-1.fc9
  =
   java-javadoc

%check is now present, and the tests pass:
    [junit] Tests run: 279, Failures: 0, Errors: 0, Time elapsed: 0.28 sec

So, because another round trip probably isn't productive, I'll approve this on
the condition that you remove the "rm -rf $RPM_BUILD_ROOT" bit from %build.  Or,
if you need it for something, let's investigate why.

APPROVE

Oops, thanks.  Yeah I think that was there before.  Will fix before commit.

New Package CVS Request
=======================
Package Name: stringtemplate
Short Description: A Java template engine
Owners: walters,konradm
Branches: F-8 EL-5
InitialCC: 
Cvsextras Commits: yes

cvs done.