Bug 440676
Summary: | Review Request: lua-filesystem - File System Library for Lua | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tim Niemueller <tim> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, michel, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-04-07 21:46:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 440681 |
Description
Tim Niemueller
2008-04-04 13:55:12 UTC
Builds fine and rpmlint is silent. The compiler is not called with the proper flags. This leads to a broken debuginfo package, among other issues. It looks like you'll need to patch the "config" file as it overwrites the passed CFLAGS. * source files match upstream: 226db0b2903e2a04de0ad0a71e53a0f629683a61172c228a3e7d416c226101ca luafilesystem-1.4.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. X compiler flags are not correct. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. X debuginfo package is not complete. * rpmlint is silent. * final provides and requires are sane: lfs.so()(64bit) lua-filesystem = 1.4.0-1.fc9 = lua >= 5.1 * %check is not present; no test suite upstream. I do not know how to test this software. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. I'm setting the CFLAGS to %{optflags} now (I didn't pass anything yet). I have to add an additional "-fPIC" or otherwise I get the following compiler error (on x86_64): /usr/bin/ld: src/lfs.o: relocation R_X86_64_32 against `a local symbol' can not be used when making a shared object; recompile with -fPIC src/lfs.o: could not read symbols: Bad value Does that satisfy debuginfo generation? New SRPM is at http://fedorapeople.org/~timn/luastuff/lua-filesystem-1.4.0-2.fc8.src.rpm Yes, debuginfo is OK now. Do note that I see the following unpleasant compiler warnings: src/lfs.c: In function 'get_dir': src/lfs.c:112: warning: implicit declaration of function 'free' src/lfs.c:112: warning: incompatible implicit declaration of built-in function 'free' which will probably cause a build failure if we ever turn on -Werror-implicit-function-declaration by default. Do note also that your passing of CFLAGS disables the default -I arguments that the makefile passes. It turns out that it's only /usr/include so you should be OK. Anyway, everything looks acceptable now. APPROVED You are right, I have created a trivial patch to fix the problem and included it in http://fedorapeople.org/~timn/luastuff/lua-filesystem-1.4.0-3.fc8.src.rpm and sent it upstream. Are you willing to take over the other reviews of my Lua packages (440677 to 440681) as well? New Package CVS Request ======================= Package Name: lua-filesystem Short Description: File System Library for Lua Owners: timn Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes I'm working on lua-posix at the moment. These packages are mostly trivial so I should be able to work through them pretty quickly. cvs done. Discussed with Tim; we'd want to eventually have the entire Lua stack on EPEL. Package Change Request ====================== Package Name: lua-filesystem New Branches: EL-4 EL-5 Owners: timn salimma cvs done. lua-filesystem-1.4.2-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/lua-filesystem-1.4.2-1.el5 |