Bug 440980

Summary: When configuring LVM, 'name' and 'logical volume name' are backwards
Product: Red Hat Enterprise Linux 5 Reporter: Chris St. Pierre <cstpierr>
Component: system-config-clusterAssignee: Ryan McCabe <rmccabe>
Status: CLOSED CURRENTRELEASE QA Contact: Cluster QE <mspqa-list>
Severity: low Docs Contact:
Priority: low    
Version: 5.0CC: bmr, cfeist, cluster-maint, duck, edamato, jim, mhuth, tao
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-22 18:05:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 462097    
Attachments:
Description Flags
Patch for /usr/share/system-config-cluster/ResourceHandler.py
none
Screenshot showing the error when creating LVM resource none

Description Chris St. Pierre 2008-04-04 19:21:53 UTC 
Description of problem:

In system-config-cluster, when you add an LVM resource, the blanks in the GUI
for 'Name' and 'Logical Volume Name' are backwards; that is, 'Name' are written
to cluster.conf as the 'lv_name' attribute, and 'Logical Volume Name' is written
as the 'name' attribute.

Additionally, since resource names must be unique across all resources,
system-config-cluster incorrectly checks the value entered for 'Logical Volume
Name' for uniqueness.

Version-Release number of selected component (if applicable):

system-config-cluster-1.0.50-1.3

How reproducible:

Every time.

Steps to Reproduce:

Create an LVM resource in system-config-cluster.

Actual results:

For 'Name' I entered 'name'; for 'Volume Group Name' I entered 'vg_name'; and
for 'Logical Volume Name' I entered 'lv_name'.  The output in cluster.conf was:

<lvm lv_name="name" name="lv_name" vg_name="vg_name"/>

Expected results:

<lvm lv_name="lv_name" name="name" vg_name="vg_name"/>
Comment 1 Jim Parsons 2008-04-14 17:32:02 UTC 
Thanks for this bug! This is a very simple fix.
Comment 2 RHEL Program Management 2008-04-14 17:39:07 UTC 
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 3 Brian Brock 2008-04-14 19:49:26 UTC 
Setting QA_ACK, clear test case.
Comment 4 Jim Parsons 2008-04-14 19:53:30 UTC 
Oops - I might have spoken to soon. It works for me on version 1.0.51-1.3

Above, you mention that you are running 1.0.50-1.3....was this a typo? If not
please upgrade to the latest version and try again.
Comment 5 Chris St. Pierre 2008-04-14 20:23:08 UTC 
That wasn't a typo.

As far as I can tell (I don't have an AP or RHCS provision), 1.0.51-1.3 hasn't 
been released yet.  It doesn't show up in Redhat's SRPMs, at least.
Comment 6 Jim Parsons 2008-04-14 20:35:16 UTC 
You are running a RHEL4 cluster, though, correct?
Comment 7 Chris St. Pierre 2008-04-14 20:40:12 UTC 
No, RHEL 5.

The 'Version' dropdown in Bugzilla only provides 3 and 4 as options; there was no 
way to choose 5, so I assumed that was some sort of overall RHCS version number 
and just chose the newest one.
Comment 8 Jim Parsons 2008-04-14 21:07:30 UTC 
Ah - good thing I asked. 

One more thought - are you looking at the python code for this resource in the
ResourceHandler.py file? In the val_lvm method, the text field names are a bit
confusing, but try and stay standard with the other resource glade file text
field names; for example, the 'name' of the resource for lvm is mapped to the
text field 'lv_name'. The LV name is mapped to a text field called 'lv_lvname'.
I checked the code and it is correct - and the correct resource name field value
is being validated for uniqueness.

*shrug*

Anyway, I just built this package for fedora. The version number is:
system-config-cluster-1.0.53-1.0

You should be able to retrieve this off of the fedoraproject.org site.

If you have any more problems, please file against the fedora version. I really
truly cannot reproduce this with your stated input above and I have even given
the code a good look.

Good luck.
Comment 11 Mark Huth 2008-09-01 22:29:34 UTC 
Created attachment 315495 [details]
Patch for /usr/share/system-config-cluster/ResourceHandler.py
Comment 12 Mark Huth 2008-09-01 22:31:25 UTC 
Created attachment 315496 [details]
Screenshot showing the error when creating LVM resource
Comment 13 Mark Huth 2008-09-01 22:36:17 UTC 
I've attached a screenshot showing that the problem is in system-config-cluster before it even writes to cluster.conf.  The screenshot shows s-c-c complaining that I haven't supplied a name for the resource when I quite clearly have (havg1).  However if I put the 'havg1' string in the 'Logical Volume Name:' field, it happily accepts that as the resource name.

Plus I've attached a patch that fixes the problem (at least for me), but there might be another/better way to fix it.

This is all from system-config-cluster-1.0.54-2.0 on RHEL4u7.  The same problem has been observed on system-config-cluster-1.0.51-2.0 on RHEL4u6 too.

Thanks,
Mark
Comment 14 Bryn M. Reeves 2008-09-12 14:01:29 UTC 
This is not fixed - reopening.
Comment 17 Perry Myers 2009-12-22 18:05:03 UTC 
The original filer of this bug should have filed it against RHEL5 instead of RHCS 4 as comment #7 suggests.  So moving this to the proper product/component.

And it looks like this has been resolve as of version system-config-cluster-1.0.55-1.0 in RHEL5 updates.  If someone finds that this is not the case we can reopen the bug, but closing it for now as CURRENTRELEASE.