Bug 441186
Summary: | Review Request: freenx-server - Free Software (GPL) Implementation of the NX Server | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Axel Thimm <axel.thimm> |
Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, gwync, ndbecker2, notting |
Target Milestone: | --- | Flags: | kevin:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-04-10 16:03:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 438660 |
Description
Axel Thimm
2008-04-07 03:31:24 UTC
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 961913bb82ee6e60d8df6f10e647bda9 freenx-server-0.7.2.tar.gz 961913bb82ee6e60d8df6f10e647bda9 ../rpm/freenx-server-0.7.2/freenx-server-0.7.2.tar.gz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Why have Release already at 6? This is a version bump from the old one, so I would think it should be able to start again at 1? 2. rpmlint says: freenx-server.src:20: E: hardcoded-library-path in /usr/lib/cups/backend freenx-server.src:95: E: hardcoded-library-path in /usr/lib/cups/backend/nxsmb freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver 0700 freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db 0700 freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db/closed 0700 freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db/failed 0700 freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/db/running 0700 freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/home 0700 freenx-server.x86_64: E: non-standard-dir-perm /var/lib/nxserver/home/.ssh 0700 freenx-server.x86_64: E: non-standard-dir-perm /var/log/nx 0700 freenx-server.x86_64: E: non-standard-uid /etc/logrotate.d/freenx nx freenx-server.x86_64: E: non-standard-uid /etc/nxserver/node.conf.sample nx freenx-server.x86_64: E: non-standard-uid /etc/nxserver nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db/closed nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db/failed nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/db/running nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/home nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/home/.ssh/authorized_keys nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver/home/.ssh nx freenx-server.x86_64: E: non-standard-uid /var/lib/nxserver nx freenx-server.x86_64: E: non-standard-uid /var/log/nx nx freenx-server.x86_64: W: dangerous-command-in-%post mv freenx-server.x86_64: W: dangling-symlink /var/lib/nxserver/home/.ssh/authorized_keys /etc/nxserver/server.id_dsa.pub.key freenx-server.x86_64: W: hidden-file-or-dir /var/lib/nxserver/home/.ssh freenx-server.x86_64: W: hidden-file-or-dir /var/lib/nxserver/home/.ssh freenx-server.x86_64: W: non-conffile-in-etc /etc/nxserver/node.conf.sample freenx-server.x86_64: W: spurious-executable-perm /usr/share/doc/freenx-server-0.7.2/nxsetup freenx-server.x86_64: W: symlink-should-be-relative /var/lib/nxserver/home/.ssh/authorized_keys /etc/nxserver/server.id_dsa.pub.key All these can be ignored I think. freenx-server.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/freenx perhaps re-name the logrotate file to 'freenx-server' ? Both of those issues are pretty minor, so if you could address them before you import, that would be great. This package is APPROVED. Thanks for the super-fast review!!! > freenx-server.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/freenx > > perhaps re-name the logrotate file to 'freenx-server' ? Yes, I missed that one! I'll fix it before importing. > Why have Release already at 6? This is a version bump from the old one, > so I would think it should be able to start again at 1? I'd like to keep it that way especially because it is the forked revision, so I can see the continuity of the package. But maybe this is overkill for the client package (the other review). New Package CVS Request ======================= Package Name: freenx-server Short Description: Free Software (GPL) Implementation of the NX Server Owners: athimm Branches: F-7 F-8 InitialCC: Jon Ciesla (limb) Cvsextras Commits: no (too many people) cvs done. Thanks! I don't see it yet in bugzilla, I wanted to move all bugs from freenx to freenx-server. But maybe I'm just impatient and bugzilla only shows this entry once the built packages appear in rawhide first? There is some kind of issue with the bugzilla sync script it seems. ;( Hopefully it will be fixed soon. It's being worked on. Sorry for the delay. (In reply to comment #6) > There is some kind of issue with the bugzilla sync script it seems. ;( > > Hopefully it will be fixed soon. It's being worked on. > Sorry for the delay. Hi, there still is no freenx-server entry for bugzilla. Thanks! Yeah, sadly it still seems to be broken. ;( Will see what I can find out. BTW I also can't commit anything to freenx-server anymore. The cvs operation claims that I'm not in the ACLs, OTOH the pkgdb has me as owner. This is probably related to the CVS outage for branching, but Jesse mail wrote that all ACLs are restored. Maybe freenx-server's was not for some reason. I didn't check with any other package (with a phony commit). ok, the bugzilla sync script is fixed now, so I see freenx-server in bugzilla now. :) also, the CVS was likely fallout after the mass branching... is it working ok now? Yes, thanks, all is working now! |