Bug 442263

Summary:	Review Request: quicksynergy - GUI for easily configuring Synergy2
Product:	[Fedora] Fedora	Reporter:	Adel Gadllah <adel.gadllah>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	almandre, fedora-package-review, notting
Target Milestone:	---	Flags:	lkundrak: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-04-24 16:54:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adel Gadllah 2008-04-13 16:20:34 UTC

Spec URL: http://tgmweb.at/gadllah/quicksynergy.spec
SRPM URL: http://tgmweb.at/gadllah/quicksynergy-0.7-1.fc8.src.rpm
Description:
QuickSynergy is a graphical interface (GUI) for easily configuring Synergy2,
an application that allows the user to share his mouse and keyboard between
two or more computers.

Comment 1 Lubomir Kundrak 2008-04-20 19:30:32 UTC

*** Bug 252133 has been marked as a duplicate of this bug. ***

Comment 2 Lubomir Kundrak 2008-04-20 19:42:12 UTC

Thanks for the package.

1.) Desktop file needs some love:

$ desktop-file-validate /home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop
/home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop: warning: key "Encoding" in
group "Desktop Entry" is deprecated
/home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop: warning: value
"Network;Application;" for key "Categories" in group "Desktop Entry" contains a
deprecated value "Application"
$ 

Icon=qslogo.png

This is invalid. You should omit the .png suffix.

Name=QuickSynergy

Hm, there is no entry key that would tell tell much about what's the application
for. How about "Mouse and Keyboard Sharing" or something similar? Check out
GenericName and Comment keys.

The same applies for "Summary:" in the spec file.

http://standards.freedesktop.org/desktop-entry-spec/latest/

2.) /usr/share/pixmaps/qslogo.png should not be executable.

-rwxr-xr-x 1 root root 3897 2008-04-20 21:34 /usr/share/pixmaps/qslogo.png
Use install -m 644 instead of install to copy it.

In other respects the package looks fine. It is legible, sane. Builds fine in
mock, uses required make and compile flags. rpmlint does not complain.

Comment 3 Adel Gadllah 2008-04-21 12:05:22 UTC

Thanks for the review.

I have fixed the problems, new srpm and spec:
http://tgmweb.at/gadllah/quicksynergy.spec
http://tgmweb.at/gadllah/quicksynergy-0.7-2.fc8.src.rpm

Comment 4 Lubomir Kundrak 2008-04-21 12:08:44 UTC

Thanks, seems fine.

APPROVED

Comment 5 Adel Gadllah 2008-04-21 12:15:58 UTC

New Package CVS Request
=======================
Package Name: quicksynergy
Short Description: Share keyboard and mouse between computers
Owners: drago01
Branches: F-7 F-8 F-9
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-04-22 17:21:01 UTC

cvs done.