Bug 442513

Summary:	Review Request: php-pear-Cache-Lite - Fast and Safe little cache system for PHP
Product:	[Fedora] Fedora	Reporter:	Remi Collet <fedora>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, fedora, notting
Target Milestone:	---	Flags:	fedora: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-04-22 18:38:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Remi Collet 2008-04-15 09:06:00 UTC

Spec URL: http://remi.fedorapeople.org/php-pear-Cache-Lite.spec
SRPM URL: http://remi.fedorapeople.org/php-pear-Cache-Lite-1.7.3-1.fc8.src.rpm
Mock Log: http://remi.fedorapeople.org/php-pear-Cache-Lite-build.log
Scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=566443

Description: 
This package is a little cache system optimized for file containers.
It is fast and safe (because it uses file locking and/or anti-corruption tests).

--
rpmlint is silent.

My goal is to remove the cache_lite bundled in GLPI to use the system one.

Comment 1 Johan Cwiklinski 2008-04-19 08:55:01 UTC

Review:
+ package builds in mock.
+ rpmlint is silent for SRPM and RPM.
+ source file are ok.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ BuildRequires are proper.
+ package installed properly.
+ Macro use appears rather consistent.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.

Comment 2 Remi Collet 2008-04-19 09:02:59 UTC

Thanks for the review.

New Package CVS Request
=======================
Package Name: php-pear-Cache-Lite
Short Description: Fast and Safe little cache system for PHP
Owners: remi
Branches: F-7, F-8, EL-5
InitialCC: 
Cvsextras Commits: yes

Comment 3 Remi Collet 2008-04-22 14:32:43 UTC

Add F-9 branch.

New Package CVS Request
=======================
Package Name: php-pear-Cache-Lite
Short Description: Fast and Safe little cache system for PHP
Owners: remi
Branches: F-7, F-8, F-9, EL-5
InitialCC: 
Cvsextras Commits: yes

Comment 4 Kevin Fenzi 2008-04-22 17:32:51 UTC

cvs done.