Bug 442749

Summary: salinfo_decode_all-0.5 prints the usage message 4 times
Product: Red Hat Enterprise Linux 4 Reporter: Milos Malik <mmalik>
Component: salinfoAssignee: Prarit Bhargava <prarit>
Status: CLOSED WONTFIX QA Contact:
Severity: low Docs Contact:
Priority: medium    
Version: 4.6   
Target Milestone: rc   
Target Release: ---   
Hardware: ia64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-12-02 13:03:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
RHEL4 fix for this issue none

Description Milos Malik 2008-04-16 16:12:43 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.8.1.13) Gecko/20080325 Fedora/2.0.0.13-1.fc8 Firefox/2.0.0.13

Description of problem:
When is the utility executed without parameters, it prints the same usage message 4 times.

Version-Release number of selected component (if applicable):
salinfo-0.5-1.13

How reproducible:
Always


Steps to Reproduce:
1. salinfo_decode_all-0.5
2. see the output

Actual Results:
It prints the usage message 4 times.

Expected Results:
It prints the usage message only once.

Additional info:

Comment 1 Milos Malik 2008-04-17 08:11:29 UTC
.qa.[root@ia64-4as-6-m1 tps]# /usr/sbin/salinfo_decode_all-0.5
/usr/sbin/salinfo_decode: option requires an argument -- D
Usage:
 salinfo_decode [-d] -t type -D directory
 salinfo_decode [-d] filename
  -d              Increment debug level
  -t type         Type of record to wait for (cmc, cpe, mca or init)
  -D directory    Directory to store the raw and decoded records
  filename        Decode a saved raw record, wthout involving SAL
/usr/sbin/salinfo_decode: option requires an argument -- D
Usage:
 salinfo_decode [-d] -t type -D directory
 salinfo_decode [-d] filename
  -d              Increment debug level
  -t type         Type of record to wait for (cmc, cpe, mca or init)
  -D directory    Directory to store the raw and decoded records
  filename        Decode a saved raw record, wthout involving SAL
/usr/sbin/salinfo_decode: option requires an argument -- D
Usage:
 salinfo_decode [-d] -t type -D directory
 salinfo_decode [-d] filename
  -d              Increment debug level
  -t type         Type of record to wait for (cmc, cpe, mca or init)
  -D directory    Directory to store the raw and decoded records
  filename        Decode a saved raw record, wthout involving SAL
/usr/sbin/salinfo_decode: option requires an argument -- D
Usage:
 salinfo_decode [-d] -t type -D directory
 salinfo_decode [-d] filename
  -d              Increment debug level
  -t type         Type of record to wait for (cmc, cpe, mca or init)
  -D directory    Directory to store the raw and decoded records
  filename        Decode a saved raw record, wthout involving SAL
.qa.[root@ia64-4as-6-m1 tps]# 

Comment 2 Milos Malik 2008-04-17 08:57:28 UTC
The salinfo_decode_all-0.5 utility expects a filename as first command line
parameter. Its usage message claims that "-d" parameter is supported, but the
reality is different.

.qa.[root@ia64-4as-6-m1 tps]# /usr/sbin/salinfo_decode_all-0.5 -d
-d/raw/.check: No such file or directory
-d/raw/.check: No such file or directory
-d/raw/.check: No such file or directory
-d/raw/.check: No such file or directory

When an unsupported command line parameter is used, the behavior is very similar.

.qa.[root@ia64-4as-6-m1 tps]# /usr/sbin/salinfo_decode_all-0.5 -h
-h/raw/.check: No such file or directory
-h/raw/.check: No such file or directory
-h/raw/.check: No such file or directory
-h/raw/.check: No such file or directory


Comment 3 Milos Malik 2008-04-17 09:24:20 UTC
I'm sorry I didn't realize that this utility is in fact a shell script.

1) The script should contain some parameter checking before it runs other commands.
2) The script should also start with something like:
#!/bin/sh

Comment 4 Prarit Bhargava 2008-04-17 13:29:49 UTC
Created attachment 302747 [details]
RHEL4 fix for this issue

Comment 5 RHEL Program Management 2008-10-31 16:49:05 UTC
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".

Comment 6 Prarit Bhargava 2008-12-02 13:03:12 UTC
With RHEL4.8 as the next release and this being a low priority issue, I'm closing this as WONTFIX.

P.