Bug 442914
Summary: | Review Request: eg - Git for mere mortals | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | James Bowes <jbowes> |
Component: | Package Review | Assignee: | Dan Horák <dan> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bkearney, bloch, fedora-package-review, notting, pahan, terje.rosten |
Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-04-25 16:37:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
James Bowes
2008-04-17 15:36:38 UTC
Updated: Spec URL: http://jbowes.fedorapeople.org/tmp/eg.spec SRPM URL: http://jbowes.fedorapeople.org/tmp/eg-0.70-2.fc9.src.rpm OK source files match upstream (diff between supplied archive and the one produced directly from git is empty) OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPL). License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (rawhide/X86_64). N/A debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. N/A no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. rpmlint output: eg.noarch: I: checking eg.noarch: W: non-conffile-in-etc /etc/bash_completion.d/eg eg.src: I: checking This a common issue of packages with "bash completion" support where /etc/bash_completion.d directory owned by the package. Trigger based solution is mentioned at http://fedoraproject.org/wiki/ToshioKuratomi/TriggerScripts. package is APPROVED Thanks for the review, Dan! New Package CVS Request ======================= Package Name: eg Short Description: Git for mere mortals Owners: jbowes Branches: F-8 Cvsextras Commits: yes cvs done. James, you should close the review bug as it was already built in Koji. Thanks Dan, I completely forgot. *** Bug 458543 has been marked as a duplicate of this bug. *** James, what's up here? I can't find this package in any repo, could you please have a look? BTW: upstream version is 0.93. (In reply to comment #9) > James, what's up here? > > I can't find this package in any repo, could you please have a look? > > BTW: upstream version is 0.93. Ha, guess i forgot to submit it to bodhi. Anyways, it's there now. I'll update to a newer version shortly. Thanks Terje! Now you can eg push to stable, eg has been in testing in over 4 weeks. |