Bug 443062
| Summary: | pvcreate does not zero swap signatures | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eric Sandeen <esandeen> | ||||
| Component: | lvm2 | Assignee: | Petr Rockai <prockai> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | agk, bmarzins, bmr, dwysocha, kzak, mbroz, prockai | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-05-19 12:27:23 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Eric Sandeen
2008-04-18 13:53:53 UTC
LVM2 wipes the first 2k (see man page) as that's where LVM2 can write its label (depending on options). There is an option already to disable wiping that. I think it's probably safe to increase the amount it wipes - though it might be better to add a check for a swap signature and require confirmation first. Ah, sorry, missed the part in the manpage about not doing the wiping if --uuid is specified. I'm on the fence about asking for confirmation if swap is found; should you check for every old signature of everything you might find? It gets cumbersome... This is also partially related to https://bugzilla.redhat.com/show_bug.cgi?id=174700 (about the warning). Increasing wipe size is certainly an option as well (I don't think this will have any adverse effects, so I'm all for doing that in CVS). Changing version to '9' as part of upcoming Fedora 9 GA. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Unless it's particularly awkward to do, I'd prefer to recognise the signature in pvcreate.c and ask people whether or not to wipe it, like we do with md superblocks, so they are aware of what they are doing. Created attachment 335395 [details]
lvm-pvcreate-wipe-swap.diff
Proposed patch to address this issue. Upstream review pending.
This has been checked in upstream. |