Bug 443305

Summary:	CIFS: tighten up default permissions on shares
Product:	[Fedora] Fedora	Reporter:	Jeff Layton <jlayton>
Component:	kernel	Assignee:	Jeff Layton <jlayton>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	11	CC:	coughlan, ssorce, staubach, steved
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-06-10 00:30:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Layton 2008-04-20 13:52:48 UTC

CIFS currently mounts shares with default permssions of 02767 when posix
extensions and cifsacl is disabled, with default ownership of root:root. This
could stand to be tightened up in my opinion.

I suggest a default mode of 02700 (leaving the setgid + !group execute bit set
to signify mandatory locking). sysadmins could then choose to loosen up those
modes if they choose.

As a bonus, I'd also suggest that we not allow chmod or create modes to override
the in memory mode when these modes can't actually be stored on the server, but
there is some resistance to that upstream.

Comment 1 Simo Sorce 2008-04-21 13:08:27 UTC

I would second this plan, the only doubt is around mandatory locking, but as
windows servers would enforce it anyway I guess it's the best thing to do.

Comment 2 Bug Zapper 2008-05-14 09:47:09 UTC

Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Jeff Layton 2009-04-06 13:46:20 UTC

Patch sent upstream this weekend and is being debated on-list.

Comment 4 Bug Zapper 2009-06-10 00:18:24 UTC

This message is a reminder that Fedora 9 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 9.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '9'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 9's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 9 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 5 Jeff Layton 2009-06-10 00:28:54 UTC

Patch pushed upstream. New default file/dir_mode is 0755.