Bug 443458

1. Relate to TABLE attachments  need to change list below:
        1.1  Separate thedata from  the table attachemts to a new table attach_data.
      Added :       TABLE attach_data
      Removed:    FIELD attachments.thedata 
              A) File: attachment.cgi
      Line: 526
      Func: view()
      Statement: 
      my $query="SELECT mimetype, filename, thedata FROM attachments WHERE
attach_id = $::FORM{'id'}";
            
             B) File: attachment.cgi
      Line: 631
      Func: get_unified_diff()
      Statement: 
      SendSQL("SELECT bug_id, description, ispatch, thedata FROM attachments
WHERE attach_id = $id");
 
               C)  File: attachment.cgi
      Line: 764
      Func: diff()
      Statement:
      SendSQL("SELECT bug_id, description, ispatch, thedata FROM attachments
WHERE attach_id = $::FORM{'id'}");
       
              D) File: attachment.cgi
      Line: 836
      Func: viewall()
      Statement:
      SendSQL("SELECT attach_id, " . Bugzilla::DB::DateFormat('creation_ts',
'%Y.%m.%d   %H:%i') . ",
            mimetype, description, ispatch, isobsolete, isprivate, " .
            Bugzilla::DB::Length('thedata', 'base64') . "
            FROM attachments WHERE bug_id = $::FORM{'bugid'} $privacy
            ORDER BY attach_id");
  
             E) File: attachment.cgi
      Line:945
      Func: insert()
      Statement:
      my $query="INSERT INTO attachments (bug_id, creation_ts, filename,
description, mimetype, ispatch, isprivate, submitter_id, thedata)
VALUES ($::FORM{'bugid'}, now(), $sqlfilename, $description, $contenttype,
$::FORM{'ispatch'},$isprivate, $::userid, ?)";
             
              F) File: attachment.cgi
      Line:1068
      Func: edit()
      Statement:
     SendSQL("SELECT description, mimetype, filename, bug_id, ispatch,
isobsolete, isprivate, " . Bugzilla::DB::Length('thedata', 'base64') . "
           FROM attachments WHERE attach_id = $::FORM{'id'}");
          
             G) File: Bugzilla/Attachment.pm
      Line:55
      Func: query()
      Statement:
     &::SendSQL("
              SELECT attach_id, " . Bugzilla::DB::DateFormat('creation_ts',
'%Y.%m.%d %H:%i:%s') . ",
              mimetype, description, ispatch, isobsolete, isprivate,
              submitter_id, " . Bugzilla::DB::Length('thedata') . "
              FROM attachments WHERE bug_id = $bugid ORDER BY attach_id
            ");

             H) File: post.cgi
      Line:787
      Func: if ($cgi->param('md5'))
      Statement:
     SendSQL("INSERT INTO attachments (bug_id, creation_ts, filename,
description, mimetype, ispatch, isprivate, submitter_id, thedata)
           VALUES ($id, now(), $sqlfilename, $description, $contenttype,
$ispatch , $isprivate, $::userid, $thedata)");



         1.2   New “Not NULL” Field : isurl,modification_time in the attachments
table.
        Added :       FIELD attachments.isurl, attachment.modification_time
                     Removed :   N/A

             A) File: attachment.cgi
      Line:945
      Func: insert()
      Statement:
      my $query="INSERT INTO attachments (bug_id, creation_ts, filename,
description, mimetype, ispatch, isprivate, submitter_id, thedata)
VALUES ($::FORM{'bugid'}, now(), $sqlfilename, $description, $contenttype,
$::FORM{'ispatch'},$isprivate, $::userid, ?)";

              B)File: Bugzilla/Attachment.pm
      Line:787
      Func: if ($cgi->param('md5'))
      Statement:
     SendSQL("INSERT INTO attachments (bug_id, creation_ts, filename,
description, mimetype, ispatch, isprivate, submitter_id, thedata)
           VALUES ($id, now(), $sqlfilename, $description, $contenttype,
$ispatch , $isprivate, $::userid, $thedata)");