Bug 443461

Created attachment 303408 [details]
The patch to fix the "rename the cust_facing,devel_whiteboard,fixed_in,internal_whiteboard,qa_whiteboard "

2.1 rename the
cust_facing,devel_whiteboard,fixed_in,internal_whiteboard,qa_whiteboard      
       Added :	    FIELD      bugs.cf_internal_whiteboard,
			       bugs.cf_devel_whiteboard,
			       bugs.cf_qa_whiteboard,
			       bugs.cf_fixed_in, 
			       bugs.cf_cust_facing
	Removed :   FIELD      bugs.cust_facing,
			       bugs.devel_whiteboard,
			       bugs.fixed_in,
			       bugs.internal_whiteboard,
			       bugs.qa_whiteboard

@@ -257,8 +257,7 @@ an "is_active" leaked into this patch
@@ -273,8 +272,7 @@ ditto
@@ -643,8 +643,7 @@

status_whiteboard didn't change?

@@ -1156,7 +1155,7 @@ parent_fixed_in doesn't really have to change; it's ok to
do so for consistancy but then we also need to search for all uses of
parent_fixed_in and verify they are all updated as well.

@@ -302,7 +302,7 @@ as above, all parent_ fields are internal to the sql not
directly in the field names.

@@ -483,11 +483,11 @@ ditto

Created attachment 303768 [details]
Patch Improve:

1.Remove the "is_active" which was leaked into this patch.
2.Agree with Rob on "parent_fixed_in doesn't really have to change" and restore
the "parent_fixed_in.
3.Add some changes for post.cgi.

> status_whiteboard didn't change?
> 

status_whiteboard deosn't change as it is not a custom field it exists as a main
database field in the upstream bugs database schema and not something that was
created or customized by redhat like the fields:
cust_facing,devel_whiteboard,fixed_in,internal_whiteboard,qa_whiteboard

those now require cf_* for custom field to be added to the front of the column name.

Created attachment 304089 [details]
Patch improve:

1.Add the field: cust_facing 
2.Add the file for search function: query.cgi,
template/en/default/search/form_advanced.html.tmpl

Please review,
Nicho

Hi nicho,

there are few places in the hwcert code that still has the custom field names
without cf_* specially in the templates. you can use something like this command
to check those places that are still not changes after you apply your patch:

# grep -rn devel_whiteboard .

also one question: Is the following template :
template/en/default/search/form_hwcert.html.tmpl
used in hwcert ? is there a search page or functionality in hwcert that will
involve those cf_* fields? 

Thanks,
Noura

Hi Noura,
Thanks  for your feedback. :)
template/en/default/search/form_hwcert.html.tmpl is not used in hwcert, I can
remove it from repo. The search page or functionality in hwcert that will
involve those cf_* fields were fixed in that patch, I will paste a new clean
patch  for it.
Those few places which still have the custom field names without cf_* work well
because I use  $var->{bug->devel_whiteboard} in Bugzilla/Bug.pm. but for the
consistency of naming, I changed them and add these changes in the new clean
patch too. I have tested this patch and it works well.

Nicho

Created attachment 304300 [details]
The new clean patch

patch looks good to me nicho.

Noura

Please commit this change to CVS and set the status to MODIFIED.

tested and run good